Sign upLogin

kubenetworks/kubevpn

View on GitHub
Star
pkg/dhcp/dhcp.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method Manager.RentIP has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
Open

func (m *Manager) RentIP(ctx context.Context) (*net.IPNet, *net.IPNet, error) {
    addrs, _ := net.InterfaceAddrs()
    var isAlreadyExistedFunc = func(ip net.IP) bool {
        for _, addr := range addrs {
            if addr == nil {
Severity: Minor
Found in pkg/dhcp/dhcp.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Manager.updateDHCPConfigMap has 15 return statements (exceeds 4 allowed).
Open

func (m *Manager) updateDHCPConfigMap(ctx context.Context, f func(ipv4 *ipallocator.Range, ipv6 *ipallocator.Range) error) error {
    cm, err := m.client.Get(ctx, config.ConfigMapPodTrafficManager, metav1.GetOptions{})
    if err != nil {
        return fmt.Errorf("failed to get configmap DHCP server, err: %v", err)
    }
Severity: Major
Found in pkg/dhcp/dhcp.go - About 1 hr to fix

    Method Manager.updateDHCPConfigMap has 56 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (m *Manager) updateDHCPConfigMap(ctx context.Context, f func(ipv4 *ipallocator.Range, ipv6 *ipallocator.Range) error) error {
    cm, err := m.client.Get(ctx, config.ConfigMapPodTrafficManager, metav1.GetOptions{})
    if err != nil {
        return fmt.Errorf("failed to get configmap DHCP server, err: %v", err)
    }
    Severity: Minor
    Found in pkg/dhcp/dhcp.go - About 1 hr to fix

      Method Manager.ForEach has 8 return statements (exceeds 4 allowed).
      Open

      func (m *Manager) ForEach(ctx context.Context, fnv4 func(net.IP), fnv6 func(net.IP)) error {
    cm, err := m.client.Get(ctx, config.ConfigMapPodTrafficManager, metav1.GetOptions{})
    if err != nil {
        return fmt.Errorf("failed to get cm DHCP server, err: %v", err)
    }
      Severity: Major
      Found in pkg/dhcp/dhcp.go - About 50 mins to fix

        Method Manager.RentIP has 7 return statements (exceeds 4 allowed).
        Open

        func (m *Manager) RentIP(ctx context.Context) (*net.IPNet, *net.IPNet, error) {
    addrs, _ := net.InterfaceAddrs()
    var isAlreadyExistedFunc = func(ip net.IP) bool {
        for _, addr := range addrs {
            if addr == nil {
        Severity: Major
        Found in pkg/dhcp/dhcp.go - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if str := cm.Data[config.KeyDHCP]; str != "" {
        var b []byte
        if b, err = base64.StdEncoding.DecodeString(str); err != nil {
            return err
        }
          Severity: Minor
          Found in pkg/dhcp/dhcp.go and 1 other location - About 35 mins to fix
          pkg/dhcp/dhcp.go on lines 169..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if str := cm.Data[config.KeyDHCP6]; str != "" {
        var b []byte
        if b, err = base64.StdEncoding.DecodeString(str); err != nil {
            return err
        }
          Severity: Minor
          Found in pkg/dhcp/dhcp.go and 1 other location - About 35 mins to fix
          pkg/dhcp/dhcp.go on lines 152..160

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status