Sign upLogin

kubenetworks/kubevpn

View on GitHub
Star
pkg/dns/dns.go

Summary

Maintainability
D
2 days
Test Coverage

Method Config.watchServiceToAddHosts has a Cognitive Complexity of 83 (exceeds 20 allowed). Consider refactoring.
Open

func (c *Config) watchServiceToAddHosts(ctx context.Context, serviceInterface v13.ServiceInterface, hosts []Entry) {
    ticker := time.NewTicker(time.Second * 15)
    defer ticker.Stop()
    immediate := make(chan struct{}, 1)
    immediate <- struct{}{}
Severity: Minor
Found in pkg/dns/dns.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Config.watchServiceToAddHosts has 89 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Config) watchServiceToAddHosts(ctx context.Context, serviceInterface v13.ServiceInterface, hosts []Entry) {
    ticker := time.NewTicker(time.Second * 15)
    defer ticker.Stop()
    immediate := make(chan struct{}, 1)
    immediate <- struct{}{}
Severity: Major
Found in pkg/dns/dns.go - About 2 hrs to fix

    Method Config.removeHosts has 52 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (c *Config) removeHosts(hosts []Entry) error {
    if len(hosts) == 0 {
        return nil
    }
    Severity: Minor
    Found in pkg/dns/dns.go - About 1 hr to fix

      Method Config.removeHosts has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func (c *Config) removeHosts(hosts []Entry) error {
    if len(hosts) == 0 {
        return nil
    }
      Severity: Minor
      Found in pkg/dns/dns.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                              if net.ParseIP(svc.Spec.ClusterIP) == nil {
                            continue
                        }
      Severity: Major
      Found in pkg/dns/dns.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if err != nil {
                            log.Errorf("Failed to add hosts(%s) to hosts: %v", entryList2String(appendHosts), err)
                        }
        Severity: Major
        Found in pkg/dns/dns.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if err != nil {
                            log.Errorf("Failed to remove hosts(%s) to hosts: %v", entryList2String(list), err)
                        }
          Severity: Major
          Found in pkg/dns/dns.go - About 45 mins to fix

            Method Config.removeHosts has 6 return statements (exceeds 4 allowed).
            Open

            func (c *Config) removeHosts(hosts []Entry) error {
    if len(hosts) == 0 {
        return nil
    }
            Severity: Major
            Found in pkg/dns/dns.go - About 40 mins to fix

              Method Config.watchServiceToAddHosts has 5 return statements (exceeds 4 allowed).
              Open

              func (c *Config) watchServiceToAddHosts(ctx context.Context, serviceInterface v13.ServiceInterface, hosts []Entry) {
    ticker := time.NewTicker(time.Second * 15)
    defer ticker.Stop()
    immediate := make(chan struct{}, 1)
    immediate <- struct{}{}
              Severity: Major
              Found in pkg/dns/dns.go - About 35 mins to fix

                Method Config.generateAppendHosts has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                Open

                func (c *Config) generateAppendHosts(serviceList []v12.Service, hosts []Entry) []Entry {
    const ServiceKubernetes = "kubernetes"
    var entryList = sets.New[Entry]().Insert(c.Hosts...).Insert(hosts...).UnsortedList()

    // 1) add only if not exist
                Severity: Minor
                Found in pkg/dns/dns.go - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function CleanupHosts has 5 return statements (exceeds 4 allowed).
                Open

                func CleanupHosts() error {
    path := GetHostFile()
    content, err2 := os.ReadFile(path)
    if err2 != nil {
        return err2
                Severity: Major
                Found in pkg/dns/dns.go - About 35 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  case <-immediate:
                    var list *v12.ServiceList
                    list, err = serviceInterface.List(ctx, v1.ListOptions{})
                    if err != nil {
                        continue
                  Severity: Major
                  Found in pkg/dns/dns.go and 1 other location - About 1 hr to fix
                  pkg/dns/dns.go on lines 124..136

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 132.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  case <-ticker.C:
                    var list *v12.ServiceList
                    list, err = serviceInterface.List(ctx, v1.ListOptions{})
                    if err != nil {
                        continue
                  Severity: Major
                  Found in pkg/dns/dns.go and 1 other location - About 1 hr to fix
                  pkg/dns/dns.go on lines 137..149

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 132.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status