Sign upLogin

kubenetworks/kubevpn

View on GitHub
Star
pkg/ssh/image.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function TransferImage has 96 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TransferImage(ctx context.Context, conf *SshConfig, imageSource, imageTarget string, out io.Writer) error {
    client, cli, err := GetClient()
    if err != nil {
        log.Errorf("Failed to get docker client: %v", err)
        return err
Severity: Major
Found in pkg/ssh/image.go - About 2 hrs to fix

    Function TransferImage has 16 return statements (exceeds 4 allowed).
    Open

    func TransferImage(ctx context.Context, conf *SshConfig, imageSource, imageTarget string, out io.Writer) error {
    client, cli, err := GetClient()
    if err != nil {
        log.Errorf("Failed to get docker client: %v", err)
        return err
    Severity: Major
    Found in pkg/ssh/image.go - About 1 hr to fix

      Function TransferImage has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
      Open

      func TransferImage(ctx context.Context, conf *SshConfig, imageSource, imageTarget string, out io.Writer) error {
    client, cli, err := GetClient()
    if err != nil {
        log.Errorf("Failed to get docker client: %v", err)
        return err
      Severity: Minor
      Found in pkg/ssh/image.go - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function PullImage has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func PullImage(ctx context.Context, platform *v1.Platform, cli *client.Client, dockerCli *command.DockerCli, img string, out io.Writer) error {
      Severity: Minor
      Found in pkg/ssh/image.go - About 45 mins to fix

        Function PullImage has 6 return statements (exceeds 4 allowed).
        Open

        func PullImage(ctx context.Context, platform *v1.Platform, cli *client.Client, dockerCli *command.DockerCli, img string, out io.Writer) error {
    var readCloser io.ReadCloser
    var plat string
    if platform != nil && platform.Architecture != "" && platform.OS != "" {
        plat = fmt.Sprintf("%s/%s", platform.OS, platform.Architecture)
        Severity: Major
        Found in pkg/ssh/image.go - About 40 mins to fix

          There are no issues that match your filters.

          Category
          Status