Sign upLogin

kubenetworks/kubevpn

View on GitHub
Star
pkg/tun/tun_windows.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function createTun has 67 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func createTun(cfg Config) (conn net.Conn, itf *net.Interface, err error) {
    if cfg.Addr == "" && cfg.Addr6 == "" {
        err = fmt.Errorf("IPv4 address and IPv6 address can not be empty at same time")
        return
    }
Severity: Minor
Found in pkg/tun/tun_windows.go - About 1 hr to fix

    Function createTun has 15 return statements (exceeds 4 allowed).
    Open

    func createTun(cfg Config) (conn net.Conn, itf *net.Interface, err error) {
    if cfg.Addr == "" && cfg.Addr6 == "" {
        err = fmt.Errorf("IPv4 address and IPv6 address can not be empty at same time")
        return
    }
    Severity: Major
    Found in pkg/tun/tun_windows.go - About 1 hr to fix

      Function createTun has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func createTun(cfg Config) (conn net.Conn, itf *net.Interface, err error) {
    if cfg.Addr == "" && cfg.Addr6 == "" {
        err = fmt.Errorf("IPv4 address and IPv6 address can not be empty at same time")
        return
    }
      Severity: Minor
      Found in pkg/tun/tun_windows.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function addTunRoutes has 6 return statements (exceeds 4 allowed).
      Open

      func addTunRoutes(tunName string, routes ...types.Route) error {
    name, err2 := net.InterfaceByName(tunName)
    if err2 != nil {
        return err2
    }
      Severity: Major
      Found in pkg/tun/tun_windows.go - About 40 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if cfg.Addr != "" {
        if ipv4, _, err = net.ParseCIDR(cfg.Addr); err != nil {
            return
        }
        var prefix netip.Prefix
        Severity: Minor
        Found in pkg/tun/tun_windows.go and 1 other location - About 45 mins to fix
        pkg/tun/tun_windows.go on lines 54..65

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if cfg.Addr6 != "" {
        if ipv6, _, err = net.ParseCIDR(cfg.Addr6); err != nil {
            return
        }
        var prefix netip.Prefix
        Severity: Minor
        Found in pkg/tun/tun_windows.go and 1 other location - About 45 mins to fix
        pkg/tun/tun_windows.go on lines 41..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 113.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status