Sign upLogin

kubenetworks/kubevpn

View on GitHub
Star
pkg/webhook/pods.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method admissionReviewHandler.handleCreate has 80 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (h *admissionReviewHandler) handleCreate(ar v1.AdmissionReview) *v1.AdmissionResponse {
    raw := ar.Request.Object.Raw
    pod := corev1.Pod{}
    deserializer := codecs.UniversalDeserializer()
    if _, _, err := deserializer.Decode(raw, nil, &pod); err != nil {
Severity: Major
Found in pkg/webhook/pods.go - About 2 hrs to fix

    Method admissionReviewHandler.handleCreate has 11 return statements (exceeds 4 allowed).
    Open

    func (h *admissionReviewHandler) handleCreate(ar v1.AdmissionReview) *v1.AdmissionResponse {
    raw := ar.Request.Object.Raw
    pod := corev1.Pod{}
    deserializer := codecs.UniversalDeserializer()
    if _, _, err := deserializer.Decode(raw, nil, &pod); err != nil {
    Severity: Major
    Found in pkg/webhook/pods.go - About 1 hr to fix

      Method admissionReviewHandler.handleCreate has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func (h *admissionReviewHandler) handleCreate(ar v1.AdmissionReview) *v1.AdmissionResponse {
    raw := ar.Request.Object.Raw
    pod := corev1.Pod{}
    deserializer := codecs.UniversalDeserializer()
    if _, _, err := deserializer.Decode(raw, nil, &pod); err != nil {
      Severity: Minor
      Found in pkg/webhook/pods.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method admissionReviewHandler.handleDelete has 5 return statements (exceeds 4 allowed).
      Open

      func (h *admissionReviewHandler) handleDelete(ar v1.AdmissionReview) *v1.AdmissionResponse {
    raw := ar.Request.OldObject.Raw
    pod := corev1.Pod{}
    deserializer := codecs.UniversalDeserializer()
    if _, _, err := deserializer.Decode(raw, nil, &pod); err != nil {
      Severity: Major
      Found in pkg/webhook/pods.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status