kujenga/goml

View on GitHub

Showing 5 of 5 total issues

Function Read has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func Read(rootDir string) (*MNIST, error) {
    trainRawImages, err := idx.ReadFile(
        filepath.Join(rootDir, "train-images-idx3-ubyte.gz"))
    if err != nil {
        return nil, err
Severity: Minor
Found in mnist/mnist.go - About 1 hr to fix

    Function Read has 7 return statements (exceeds 4 allowed).
    Open

    func Read(rdr io.Reader) (*IDX, error) {
        // Read in the "magic number" which provides us with information about
        // the format of the data in this IDX file.
        magic := make([]byte, 4)
        n, err := rdr.Read(magic)
    Severity: Major
    Found in idx/idx.go - About 45 mins to fix

      Function Read has 5 return statements (exceeds 4 allowed).
      Open

      func Read(rootDir string) (*MNIST, error) {
          trainRawImages, err := idx.ReadFile(
              filepath.Join(rootDir, "train-images-idx3-ubyte.gz"))
          if err != nil {
              return nil, err
      Severity: Major
      Found in mnist/mnist.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for i := range out.TrainInputs {
                out.TrainInputs[i] = make([]float32, 28*28)
                for j := range out.TrainInputs[i] {
                    out.TrainInputs[i][j] = float32(
                        trainRawImages.Data[i*28*28+j])/255.0*0.99 + 0.01
        Severity: Minor
        Found in mnist/mnist.go and 1 other location - About 35 mins to fix
        mnist/mnist.go on lines 69..75

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            for i := range out.TestInputs {
                out.TestInputs[i] = make([]float32, 28*28)
                for j := range out.TestInputs[i] {
                    out.TestInputs[i][j] = float32(
                        testRawImages.Data[i*28*28+j])/255.0*0.99 + 0.01
        Severity: Minor
        Found in mnist/mnist.go and 1 other location - About 35 mins to fix
        mnist/mnist.go on lines 62..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language