Sign upLogin

kwn/number-to-words

View on GitHub
Star
src/Legacy/Numbers/Words/Locale/Mk.php

Summary

Maintainability
F
5 days
Test Coverage
A
94%

Function showDigitsGroup has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    private function showDigitsGroup(int $num, int $gender = 0, bool $last = false): string
    {
        /* A storage array for the return string.
             Positions 1, 3, 5 are intended for digit words
             and everything else (0, 2, 4) for "and" words.
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Mk.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toWords has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    protected function toWords(int $num = 0): string
    {
        $ret = [];

        $retMinus = '';
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Mk.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Mk.php has 322 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace NumberToWords\Legacy\Numbers\Words\Locale;

use NumberToWords\Legacy\Numbers\Words;
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Mk.php - About 3 hrs to fix

    Method showDigitsGroup has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function showDigitsGroup(int $num, int $gender = 0, bool $last = false): string
    {
        /* A storage array for the return string.
             Positions 1, 3, 5 are intended for digit words
             and everything else (0, 2, 4) for "and" words.
    Severity: Major
    Found in src/Legacy/Numbers/Words/Locale/Mk.php - About 3 hrs to fix

      Method toWords has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function toWords(int $num = 0): string
    {
        $ret = [];

        $retMinus = '';
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Mk.php - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

                            if ($pow == 1) {
                        $ret[$j] .= $this->showDigitsGroup(
                                $numGroups[$i],
                                0,
                                !$this->lastAnd && $i
        Severity: Major
        Found in src/Legacy/Numbers/Words/Locale/Mk.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private static $exponent = [
        0 => '',
        3 => 'илјада',
        6 => 'милион',
        9 => 'милјард',
          Severity: Major
          Found in src/Legacy/Numbers/Words/Locale/Mk.php and 1 other location - About 2 days to fix
          src/Legacy/Numbers/Words/Locale/Bg.php on lines 52..155

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 517.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status