Sign upLogin

kwn/number-to-words

View on GitHub
Star
src/Legacy/Numbers/Words/Locale/Ms.php

Summary

Maintainability
F
1 wk
Test Coverage
B
88%

Function toWords has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

    protected function toWords($number, $power = 0)
    {
        $return = '';

        if ($number < 0) {
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Ms.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method toWords has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function toWords($number, $power = 0)
    {
        $return = '';

        if ($number < 0) {
Severity: Major
Found in src/Legacy/Numbers/Words/Locale/Ms.php - About 4 hrs to fix

    Avoid too many return statements within this method.
    Open

            return $return;
    Severity: Major
    Found in src/Legacy/Numbers/Words/Locale/Ms.php - About 30 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function toWords($number, $power = 0)
    {
        $return = '';

        if ($number < 0) {
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Ms.php and 1 other location - About 5 days to fix
      src/Legacy/Numbers/Words/Locale/Id.php on lines 105..237

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 909.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $currency = strtoupper($currency);

        if (!array_key_exists($currency, static::$currencyNames)) {
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Ms.php and 1 other location - About 4 hrs to fix
      src/Legacy/Numbers/Words/Locale/Id.php on lines 246..270

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 179.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private static $exponent = [
        0 => [''],
        3 => ['ribu'],
        6 => ['juta'],
        9 => ['bilion'],
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Ms.php and 1 other location - About 2 hrs to fix
      src/Legacy/Numbers/Words/Locale/Id.php on lines 16..30

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status