Sign upLogin

kwn/number-to-words

View on GitHub
Star
src/Legacy/Numbers/Words/Locale/Nl.php

Summary

Maintainability
D
2 days
Test Coverage
A
92%

Function toWords has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Open

    protected function toWords($num, $power = 0, $powsuffix = '')
    {
        $ret = '';
        $hasPower = false;;
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Nl.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method toWords has 130 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function toWords($num, $power = 0, $powsuffix = '')
    {
        $ret = '';
        $hasPower = false;;
Severity: Major
Found in src/Legacy/Numbers/Words/Locale/Nl.php - About 5 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                            if ($powsuffix != '') {
                            $cursuffix .= $this->wordSeparator . $powsuffix;
                        }
    Severity: Major
    Found in src/Legacy/Numbers/Words/Locale/Nl.php - About 45 mins to fix

      Avoid too many return statements within this method.
      Open

              return $ret;
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Nl.php - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    case 1:
                switch ($d) {
                    case 0:
                        $ret .= $this->wordSeparator . 'tien';
                        break;
        Severity: Major
        Found in src/Legacy/Numbers/Words/Locale/Nl.php and 1 other location - About 3 hrs to fix
        src/Legacy/Numbers/Words/Locale/Cs.php on lines 171..201

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 144.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                switch (strlen($num)) {
            case 3:
                $h = (int) substr($num, -3, 1);

            case 2:
        Severity: Major
        Found in src/Legacy/Numbers/Words/Locale/Nl.php and 5 other locations - About 1 hr to fix
        src/Legacy/Numbers/Words/Locale/Cs.php on lines 107..121
        src/Legacy/Numbers/Words/Locale/Dk.php on lines 110..124
        src/Legacy/Numbers/Words/Locale/Et.php on lines 195..209
        src/Legacy/Numbers/Words/Locale/Lt.php on lines 93..107
        src/Legacy/Numbers/Words/Locale/Sv.php on lines 115..129

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status