Sign upLogin

kylekatarnls/business-day

View on GitHub
Star

Showing 117 of 118 total issues

Avoid assigning values to variables in if clauses and the like (line '30', column '19').
Open

    public function boot()
    {
        $config = $this->app->get('config')->get('carbon.holidays');

        if ($config instanceof Closure) {
Severity: Minor
Found in src/Cmixin/BusinessDay/Laravel/ServiceProvider.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '31', column '27').
Open

    public function boot()
    {
        $config = $this->app->get('config')->get('carbon.holidays');

        if ($config instanceof Closure) {
Severity: Minor
Found in src/Cmixin/BusinessDay/Laravel/ServiceProvider.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid using static access to class '\Illuminate\Support\Facades\Date' in method 'boot'.
Open

                (($now = Date::now()) instanceof DateTimeInterface) &&
Severity: Minor
Found in src/Cmixin/BusinessDay/Laravel/ServiceProvider.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Cmixin\BusinessDay\Util\Context' in method 'addExtraWorkday'.
Open

            return isset($this) && Context::isNotMixin($this, $mixin) ? $this : null;
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidaysList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Cmixin\BusinessDay\Util\Context' in method 'setObservedHolidaysZone'.
Open

            return isset($this) && Context::isNotMixin($this, $mixin) ? $this : (isset($self) ? $self : null);
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidayObserver.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Cmixin\BusinessDay\Util\Context' in method 'getObserveHolidayMethod'.
Open

            return isset($this) && Context::isNotMixin($this, $mixin) ? $this : (isset($self) ? $self : null);
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidayObserver.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid assigning values to variables in if clauses and the like (line '104', column '42').
Open

    public function setHolidaysRegion()
    {
        $mixin = $this;

        /**
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidaysList.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid using static access to class '\Cmixin\BusinessDay\Util\FileConfig' in method 'setHolidaysRegion'.
Open

                        FileConfig::use($file, $mixin, $nation);
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidaysList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Cmixin\BusinessDay\Util\Context' in method 'pushToBDList'.
Open

            return isset($this) && Context::isNotMixin($this, $mixin) ? $this : null;
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidaysList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Cmixin\BusinessDay\Util\Context' in method 'pushWorkday'.
Open

            return isset($this) && Context::isNotMixin($this, $mixin) ? $this : null;
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidaysList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid assigning values to variables in if clauses and the like (line '99', column '34').
Open

    public function setHolidaysRegion()
    {
        $mixin = $this;

        /**
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidaysList.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid using static access to class 'Cmixin\BusinessDay\Calendar\MissingCalendarExtensionException' in method 'requireFunction'.
Open

            throw MissingCalendarExtensionException::forFunction($function);
Severity: Minor
Found in src/Cmixin/BusinessDay/Calendar/CalendarExtensionChecker.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Cmixin\BusinessDay\Util\Context' in method 'setHolidayObserveStatus'.
Open

            return isset($this) && Context::isNotMixin($this, $mixin) ? $this : (isset($self) ? $self : null);
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidayObserver.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid assigning values to variables in if clauses and the like (line '125', column '28').
Open

    protected function handleModifiers($dateTime, $condition, $substitute, $after, $before)
    {
        if ($condition && ($action = $this->getConditionalModifier(explode(' and ', $condition), $dateTime))) {
            $dateTime = $dateTime->modify($action);
        }
Severity: Minor
Found in src/Cmixin/BusinessDay/Calculator/HolidayCalculator.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid using static access to class '\Cmixin\BusinessDay\Util\Context' in method 'setHolidayName'.
Open

            return isset($this) && Context::isNotMixin($this, $mixin) ? $this : null;
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidaysList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Cmixin\BusinessDay\Util\FileConfig' in method 'setHolidaysRegion'.
Open

                FileConfig::use($file, $mixin, $region);
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidaysList.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused local variables such as '$mixin'.
Open

        $mixin = $this;
Severity: Minor
Found in src/Cmixin/BusinessDay/HolidayData.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid using static access to class '\Cmixin\BusinessDay' in method 'getHolidayDate'.
Open

                if (BusinessDay::shouldRaiseMissingCalendarExtensionException()) {
Severity: Minor
Found in src/Cmixin/BusinessDay/Calculator/HolidayCalculator.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Cmixin\BusinessDay' in method 'boot'.
Open

            BusinessDay::enable($classes, $config);
Severity: Minor
Found in src/Cmixin/BusinessDay/Laravel/ServiceProvider.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid assigning values to variables in if clauses and the like (line '73', column '13').
Open

    public function next()
    {
        if ($holiday = array_shift($this->nextHolidays)) {
            return $this->getHolidayDate($holiday[0], $holiday[1]);
        }
Severity: Minor
Found in src/Cmixin/BusinessDay/Calculator/HolidayCalculator.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Severity
Category
Status
Source
Language