Sign upLogin

kylekatarnls/business-day

View on GitHub
Star
src/Cmixin/BusinessDay/Holiday.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Argument 1 (mixin) is \Cmixin\BusinessDay\Holiday|\Cmixin\BusinessDay\HolidayData|\Cmixin\BusinessDay\HolidaysList|\Cmixin\BusinessDay\MixinBase|\Cmixin\BusinessDay\YearCrawler but \Cmixin\BusinessDay\Calculator\MixinConfigPropagator::getHolidayGetter() takes \Cmixin\BusinessDay\BusinessCalendar defined at /code/src/Cmixin/BusinessDay/Calculator/MixinConfigPropagator.php:61
Open

            $holidayGetter = MixinConfigPropagator::getHolidayGetter($mixin, $self);
Severity: Minor
Found in src/Cmixin/BusinessDay/Holiday.php by phan

Argument 1 (mixin) is \Cmixin\BusinessDay\Holiday|\Cmixin\BusinessDay\HolidayData|\Cmixin\BusinessDay\HolidaysList|\Cmixin\BusinessDay\MixinBase|\Cmixin\BusinessDay\YearCrawler but \Cmixin\BusinessDay\Calculator\MixinConfigPropagator::getExtraWorkdayGetter() takes \Cmixin\BusinessDay\BusinessCalendar defined at /code/src/Cmixin/BusinessDay/Calculator/MixinConfigPropagator.php:71
Open

            $workdayGetter = MixinConfigPropagator::getExtraWorkdayGetter($mixin, $self);
Severity: Minor
Found in src/Cmixin/BusinessDay/Holiday.php by phan

Argument 1 (mixin) is \Cmixin\BusinessDay\Holiday|\Cmixin\BusinessDay\HolidayData|\Cmixin\BusinessDay\HolidaysList|\Cmixin\BusinessDay\MixinBase|\Cmixin\BusinessDay\YearCrawler but \Cmixin\BusinessDay\Calculator\MixinConfigPropagator::setHolidayGetter() takes \Cmixin\BusinessDay\BusinessCalendar defined at /code/src/Cmixin/BusinessDay/Calculator/MixinConfigPropagator.php:56
Open

                $mixin,
Severity: Minor
Found in src/Cmixin/BusinessDay/Holiday.php by phan

Argument 1 (mixin) is \Cmixin\BusinessDay\Holiday|\Cmixin\BusinessDay\HolidayData|\Cmixin\BusinessDay\HolidaysList|\Cmixin\BusinessDay\MixinBase|\Cmixin\BusinessDay\YearCrawler but \Cmixin\BusinessDay\Calculator\MixinConfigPropagator::setExtraWorkdayGetter() takes \Cmixin\BusinessDay\BusinessCalendar defined at /code/src/Cmixin/BusinessDay/Calculator/MixinConfigPropagator.php:66
Open

                $mixin,
Severity: Minor
Found in src/Cmixin/BusinessDay/Holiday.php by phan

Rename "$holidayGetter" which has the same name as the field declared at line 24.
Open

            $holidayGetter = MixinConfigPropagator::getHolidayGetter($mixin, $self);
Severity: Major
Found in src/Cmixin/BusinessDay/Holiday.php by sonar-php

Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

Noncompliant Code Example

class Foo {
  public $myField;

  public function doSomething() {
    $myField = 0;
    ...
  }
}

See

Rename "$workdayGetter" which has the same name as the field declared at line 34.
Open

            $workdayGetter = MixinConfigPropagator::getExtraWorkdayGetter($mixin, $self);
Severity: Major
Found in src/Cmixin/BusinessDay/Holiday.php by sonar-php

Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

Noncompliant Code Example

class Foo {
  public $myField;

  public function doSomething() {
    $myField = 0;
    ...
  }
}

See

There are no issues that match your filters.

Category
Status