Sign upLogin

kylekatarnls/business-time

View on GitHub
Star

Showing 227 of 228 total issues

Avoid deeply nested control flow statements.
Open

                        if (preg_match('/^(public|protected)\s+function\s+(\S+)\(.*\)(\s*\{)?$/', trim($code[$i]), $match)) {
                            break;
                        }
Severity: Major
Found in types.php - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            for ($i = $length - 2; $i >= max(0, $length - 42); $i--) {
                            $doc = $lines[$i].$doc;

                            if (preg_match('/\s*\/\*{2,}\s*/', $lines[$i])) {
                                $methodDocBlock = trim($doc) ?: $methodDocBlock;
    Severity: Major
    Found in types.php - About 45 mins to fix

      Method parseMethodDoc has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $name,
        int $length,
        string $className,
        string $defaultClass,
        array $code,
      Severity: Minor
      Found in types.php - About 45 mins to fix

        Missing class import via use statement (line '41', column '33').
        Open

                        $function = new ReflectionFunction($closure);
        Severity: Minor
        Found in types.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Missing class import via use statement (line '128', column '39').
        Open

                                $method = new ReflectionMethod($className, $name);
        Severity: Minor
        Found in types.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Remove error control operator '@' on line 90.
        Open

            public function getSetterParameters()
    {
        @trigger_error(
            'The DefinitionParser::getSetterParameters method is deprecated,'.
            ' use DefinitionParser::getDefinition() instead which also support split argument list.',
        Severity: Minor
        Found in src/BusinessTime/DefinitionParser.php by phpmd

        ErrorControlOperator

        Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

        Example

        function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

        Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

        Missing class import via use statement (line '130', column '39').
        Open

                                $method = new ReflectionMethod($defaultClass, $name);
        Severity: Minor
        Found in types.php by phpmd

        MissingImport

        Since: 2.7.0

        Importing all external classes in a file through use statements makes them clearly visible.

        Example

        function make() {
    return new \stdClass();
}

        Source http://phpmd.org/rules/cleancode.html#MissingImport

        Function getOpeningHours has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getOpeningHours($mode = null, $context = null)
    {
        switch ($mode) {
            case static::GLOBAL_MODE:
                return $this->openingHours;
        Severity: Minor
        Found in src/BusinessTime/MixinBase.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid assigning values to variables in if clauses and the like (line '310', column '26').
        Open

            public function getOpeningHours($mode = null, $context = null)
    {
        switch ($mode) {
            case static::GLOBAL_MODE:
                return $this->openingHours;
        Severity: Minor
        Found in src/BusinessTime/MixinBase.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid assigning values to variables in if clauses and the like (line '313', column '29').
        Open

            public function getOpeningHours($mode = null, $context = null)
    {
        switch ($mode) {
            case static::GLOBAL_MODE:
                return $this->openingHours;
        Severity: Minor
        Found in src/BusinessTime/MixinBase.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class '\Carbon\Carbon' in method '__construct'.
        Open

                $this->unit = ucfirst(Carbon::pluralUnit($unit));
        Severity: Minor
        Found in src/BusinessTime/DiffCalculator.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class 'BusinessTime\Normalizer' in method 'normalizeDay'.
        Open

                    return Normalizer::normalizeDay($day, static::$days);
        Severity: Minor
        Found in src/BusinessTime/MixinBase.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\Spatie\OpeningHours\OpeningHours' in method 'convertOpeningHours'.
        Open

                        return OpeningHours::create($hours);
        Severity: Minor
        Found in src/BusinessTime/MixinBase.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\BusinessTime\Normalizer' in method 'isOpenOn'.
        Open

                                : Normalizer::normalizeDay($day)
        Severity: Minor
        Found in src/BusinessTime/Traits/IsMethods.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid assigning values to variables in if clauses and the like (line '58', column '23').
        Open

            private function getCarbonClasses(): array
    {
        $classes = array_filter([
            Carbon::class,
            CarbonImmutable::class,
        Severity: Minor
        Found in src/BusinessTime/Laravel/ServiceProvider.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class '\Carbon\CarbonImmutable' in method '__call'.
        Open

                    $date = $this->passBusinessTimeMethods(CarbonImmutable::now());
        Severity: Minor
        Found in src/BusinessTime/Schedule.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid assigning values to variables in if clauses and the like (line '309', column '26').
        Open

            public function getOpeningHours($mode = null, $context = null)
    {
        switch ($mode) {
            case static::GLOBAL_MODE:
                return $this->openingHours;
        Severity: Minor
        Found in src/BusinessTime/MixinBase.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid using static access to class 'BusinessTime\BusinessTimeWrapper' in method 'create'.
        Open

                return new self(BusinessTimeWrapper::create($openingHours));
        Severity: Minor
        Found in src/BusinessTime/Schedule.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        The method getScheduleDoc() has an NPath complexity of 1729. The configured NPath complexity threshold is 200.
        Open

            public function getScheduleDoc($defaultClass, $source, $boot)
    {
        $methods = [];
        $source = str_replace('\\', '/', realpath($source));
        $sourceLength = strlen($source);
        Severity: Minor
        Found in types.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
    function bar() {
        // lots of complicated code
    }
}

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        Avoid using static access to class '\Cmixin\BusinessTime' in method 'boot'.
        Open

                BusinessTime::enable(
            $this->getCarbonClasses(),
            array_merge($config, $openingHours)
        );
        Severity: Minor
        Found in src/BusinessTime/Laravel/ServiceProvider.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Severity
        Category
        Status
        Source
        Language