Showing 27 of 27 total issues
File momentum-server.spec.js
has 794 lines of code (exceeds 250 allowed). Consider refactoring. Open
const AdapterInterface = require('./adapter/interface');
const MomentumServer = require('./momentum-server');
const emulateApp = require('../spec/emulate-app');
class FoobarAdapter extends AdapterInterface {
File momentum-server.js
has 724 lines of code (exceeds 250 allowed). Consider refactoring. Open
const net = require('net');
const express = require('express');
const bodyParser = require('body-parser');
const randomString = require('randomstring');
const fs = require('fs');
File momentum.js
has 521 lines of code (exceeds 250 allowed). Consider refactoring. Open
(function (root, factory) {
/* istanbul ignore next */
if (typeof define === "function" && define.amd) {
define(factory);
} else if (typeof exports === "object") {
MomentumServer
has 59 functions (exceeds 20 allowed). Consider refactoring. Open
class MomentumServer {
/**
* Init a momentum server with an adapter (arguments
* are passed to the adapter constructor).
File momentum.test.js
has 483 lines of code (exceeds 250 allowed). Consider refactoring. Open
describe('Momentum', function () {
beforeEach(function () {
jasmine.DEFAULT_TIMEOUT_INTERVAL = 60000;
});
it('should be available on window', function () {
Function offCollection
has 62 lines of code (exceeds 25 allowed). Consider refactoring. Open
var offCollection = animals.onChange(function (event) {
/* istanbul ignore else */
if (event.item.name === dog) {
offCollection();
expect(event.item.name).toBe(dog);
Function addListenRoute
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
addListenRoute() {
this.addJsonRoute('listen', (request, response) => {
const token = request.body.token;
const collection = request.body.collection;
if (!collection) {
Function exports
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports = config => {
const params = {
basePath: '',
frameworks: [
'express-http-server',
Function proxyDataBaseRequest
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
proxyDataBaseRequest(mode, request, response, allowedMethods, transform) {
const method = request.body.method;
const args = request.body.args;
const token = request.body.token;
Function Collection
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
function Collection(momentum, name, data) {
this._momentum = momentum;
this._name = name;
this._changeEvents = [];
this.append(data);
Function start
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
start(app = null) {
let appPort = null;
if (!isNaN(app)) {
appPort = app;
app = null;
Function addOnRoute
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
addOnRoute() {
this.addRoute('on', (request, response) => {
request.setTimeout(0);
let end;
let timeout = setTimeout(() => {
Function end
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
var end = function () {
if (first) {
first = false;
return;
Similar blocks of code found in 2 locations. Consider refactoring. Open
Collection.prototype.updateMany = function (filter, update, options, callback) {
var args = [filter, update];
callback = this.parseArguments(args, options, callback);
return this.emit('updateMany', args, callback);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 68.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
Collection.prototype.updateOne = function (item, update, options, callback) {
var args = [item, update];
callback = this.parseArguments(args, options, callback);
return this.emit('updateOne', args, callback);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 68.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function find
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
find(collection, filter, projection, methods) {
const query = this.callOnCollection(collection, 'find', [filter, projection]);
let callee;
const promise = new Promise((resolve, reject) => {
callee = () => {
Function addReadyRoute
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
addReadyRoute() {
this.addRoute('ready', (request, response) => {
const readyCallback = () => {
const ip = getIpFromRequest(request);
const tokens = this.options.collectionPrefix + 'tokens';
Function _stop
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
this._stop = momentum.on(function (event) {
if (event.listen.collection === name && !event.listen.filter) {
switch (event.args[0]) {
case 'insert':
this.append(event.args[1].items || [event.args[1].item]);
Function on
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
Momentum.prototype.on = function (callback) {
if (typeof callback !== 'function') {
return function () {};
}
Function onReady
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
Momentum.prototype.onReady = function (callback) {
if (this.isReady) {
execute(callback, this.readyError);
} else if (this.readyCallbacks.push(callback) === 1) {
var retry = function () {