Sign upLogin

kylekatarnls/nodejs-php-fallback

View on GitHub
Star

Showing 54 of 54 total issues

The class NodejsPhpFallback has an overall complexity of 79 which is very high. The configured complexity threshold is 50.
Open

class NodejsPhpFallback
{
    protected static $modulePaths = [];
    protected static $maxInstallRetry = 3;
    protected $nodePath;
Severity: Minor
Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

NodejsPhpFallback has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class NodejsPhpFallback
{
    protected static $modulePaths = [];
    protected static $maxInstallRetry = 3;
    protected $nodePath;
Severity: Minor
Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 3 hrs to fix

    File NodejsPhpFallback.php has 279 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace NodejsPhpFallback;

use Composer\Composer;
    Severity: Minor
    Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 2 hrs to fix

      Function getNpmConfig has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function getNpmConfig(Composer $composer, $key = null)
    {
        $vendorDir = $composer->getConfig()->get('vendor-dir');

        $npm = [];
      Severity: Minor
      Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method askForInstall has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function askForInstall(Event $event, $npmConfirm, $npm)
    {
        $io = $event->getIO();

        if (!$io->isInteractive()) {
      Severity: Minor
      Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

        Method installPackages has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function installPackages($npm, $onFound = null)
    {
        if (!count($npm)) {
            return true;
        }
        Severity: Minor
        Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

          Function installPackages has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function installPackages($npm, $onFound = null)
    {
        if (!count($npm)) {
            return true;
        }
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid variables with short names like $io. Configured minimum length is 3.
          Open

                  $io = $event->getIO();
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $io. Configured minimum length is 3.
          Open

              protected static function getGlobalInstallChoice(IOInterface $io, $message)
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $io. Configured minimum length is 3.
          Open

                  $io = $event->getIO();
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $io. Configured minimum length is 3.
          Open

              protected $io;
          Severity: Minor
          Found in src/NodejsPhpFallback/ComposerPlugin.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $io. Configured minimum length is 3.
          Open

              public function uninstall(Composer $composer, IOInterface $io)
          Severity: Minor
          Found in src/NodejsPhpFallback/ComposerPlugin.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $io. Configured minimum length is 3.
          Open

              public function activate(Composer $composer, IOInterface $io)
          Severity: Minor
          Found in src/NodejsPhpFallback/ComposerPlugin.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $io. Configured minimum length is 3.
          Open

              public function deactivate(Composer $composer, IOInterface $io)
          Severity: Minor
          Found in src/NodejsPhpFallback/ComposerPlugin.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Remove error control operator '@' on line 197.
          Open

              protected static function getGlobalInstallChoice(IOInterface $io, $message)
    {
        $answer = getenv('NODEJS_PHP_FALLBACK_ANSWER');

        if (is_string($answer) && $answer !== '') {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          ErrorControlOperator

          Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

          Example

          function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

          Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

          Function getGlobalInstallChoice has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected static function getGlobalInstallChoice(IOInterface $io, $message)
    {
        $answer = getenv('NODEJS_PHP_FALLBACK_ANSWER');

        if (is_string($answer) && $answer !== '') {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function askForInstall has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function askForInstall(Event $event, $npmConfirm, $npm)
    {
        $io = $event->getIO();

        if (!$io->isInteractive()) {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid using static access to class 'NodejsPhpFallback\NodejsPhpFallback' in method 'onAutoloadDump'.
          Open

                  NodejsPhpFallback::install($event);
          Severity: Minor
          Found in src/NodejsPhpFallback/ComposerPlugin.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid unused parameters such as '$composer'.
          Open

              public function deactivate(Composer $composer, IOInterface $io)
          Severity: Minor
          Found in src/NodejsPhpFallback/ComposerPlugin.php by phpmd

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          The method askForInstall() has an NPath complexity of 336. The configured NPath complexity threshold is 200.
          Open

              public static function askForInstall(Event $event, $npmConfirm, $npm)
    {
        $io = $event->getIO();

        if (!$io->isInteractive()) {
          Severity: Minor
          Found in src/NodejsPhpFallback/NodejsPhpFallback.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
    function bar() {
        // lots of complicated code
    }
}

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          Severity
          Category
          Status
          Source
          Language