src/NodejsPhpFallback/React.php
Method compile
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function compile()
{
$path = $this->getPath('source.jsx');
if (!$this->lastFile) {
$this->lastFile = sys_get_temp_dir() . DIRECTORY_SEPARATOR . preg_replace('/\.jsx$/i', '', basename($path)) . '.js';
Missing class import via use statement (line '69', column '23'). Open
Open
throw new \ErrorException("Command error: $output", 2);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid assigning values to variables in if clauses and the like (line '33', column '15'). Open
Open
public function getSourceMap()
{
if (!($file = $this->getSourceMapFile())) {
return;
}
- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}