Sign upLogin

kylekatarnls/react

View on GitHub
Star
src/NodejsPhpFallback/ReactFallback.php

Summary

Maintainability
B
5 hrs
Test Coverage
A
100%

Method elementToJs has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function elementToJs($element, $content, $indent = 0)
    {
        $name = $element->getName();
        if (in_array($name, $this->htmlTags)) {
            $name = json_encode($name);
Severity: Minor
Found in src/NodejsPhpFallback/ReactFallback.php - About 1 hr to fix

    Function parseJsx has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function parseJsx()
    {
        $this->result = '';
        $this->buffer = $this->source;
        while (mb_strlen($this->buffer)) {
    Severity: Minor
    Found in src/NodejsPhpFallback/ReactFallback.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function elementToJs has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function elementToJs($element, $content, $indent = 0)
    {
        $name = $element->getName();
        if (in_array($name, $this->htmlTags)) {
            $name = json_encode($name);
    Severity: Minor
    Found in src/NodejsPhpFallback/ReactFallback.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parseJsx has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function parseJsx()
    {
        $this->result = '';
        $this->buffer = $this->source;
        while (mb_strlen($this->buffer)) {
    Severity: Minor
    Found in src/NodejsPhpFallback/ReactFallback.php - About 1 hr to fix

      The method elementToJs() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
      Open

          protected function elementToJs($element, $content, $indent = 0)
    {
        $name = $element->getName();
        if (in_array($name, $this->htmlTags)) {
            $name = json_encode($name);
      Severity: Minor
      Found in src/NodejsPhpFallback/ReactFallback.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Avoid using undefined variables such as '$matches' which will lead to PHP notices.
      Open

                  if ($this->startWithTag($content, $matches)) {
      Severity: Minor
      Found in src/NodejsPhpFallback/ReactFallback.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$matches' which will lead to PHP notices.
      Open

                      $args[] = $this->elementToJs($xml, isset($matches[1]) ? $matches[1] : '', $indent + 1);
      Severity: Minor
      Found in src/NodejsPhpFallback/ReactFallback.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$matches' which will lead to PHP notices.
      Open

                      $args[] = $this->elementToJs($xml, isset($matches[1]) ? $matches[1] : '', $indent + 1);
      Severity: Minor
      Found in src/NodejsPhpFallback/ReactFallback.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$matches' which will lead to PHP notices.
      Open

                      $xml = simplexml_load_string($matches[0]);
      Severity: Minor
      Found in src/NodejsPhpFallback/ReactFallback.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$matches' which will lead to PHP notices.
      Open

                      $content = mb_substr($content, mb_strlen($matches[0]));
      Severity: Minor
      Found in src/NodejsPhpFallback/ReactFallback.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid unused local variables such as '$spaces'.
      Open

              $spaces = str_repeat(' ', $indent * 2);
      Severity: Minor
      Found in src/NodejsPhpFallback/ReactFallback.php by phpmd

      UnusedLocalVariable

      Since: 0.2

      Detects when a local variable is declared and/or assigned, but not used.

      Example

      class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

      Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

      Avoid excessively long variable names like $validXmlTagNameOtherCharacters. Keep variable name length under 20.
      Open

          protected $validXmlTagNameOtherCharacters = '0-9\\p{L}\\.\\-';
      Severity: Minor
      Found in src/NodejsPhpFallback/ReactFallback.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      Avoid excessively long variable names like $validXmlTagNameStartCharacters. Keep variable name length under 20.
      Open

          protected $validXmlTagNameStartCharacters = 'A-Za-z\\p{L}_:';
      Severity: Minor
      Found in src/NodejsPhpFallback/ReactFallback.php by phpmd

      LongVariable

      Since: 0.2

      Detects when a field, formal or local variable is declared with a long name.

      Example

      class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

      Source https://phpmd.org/rules/naming.html#longvariable

      There are no issues that match your filters.

      Category
      Status