Sign upLogin

laboiteproject/lenuage

View on GitHub
Star
laboite/static/js/gfx.js

Summary

Maintainability
D
1 day
Test Coverage

Function drawHex has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

function drawHex(x0, y0, hex_bitmap, width, height, color, bg) {
Severity: Major
Found in laboite/static/js/gfx.js - About 50 mins to fix

    Function draw has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function draw(x0, y0, bitmap, width, height, color, bg) {
    Severity: Major
    Found in laboite/static/js/gfx.js - About 50 mins to fix

      Function printText has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function printText(x, y, text, color, bg) {
      Severity: Minor
      Found in laboite/static/js/gfx.js - About 35 mins to fix

        Function drawRect has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function drawRect(x0, y0,  width,  height, color) {
        Severity: Minor
        Found in laboite/static/js/gfx.js - About 35 mins to fix

          Function drawChar has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function drawChar(x0, y0, character, color, bg){
          Severity: Minor
          Found in laboite/static/js/gfx.js - About 35 mins to fix

            Function fillRect has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function fillRect(x0, y0,  width,  height, color) {
            Severity: Minor
            Found in laboite/static/js/gfx.js - About 35 mins to fix

              Function draw has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              function draw(x0, y0, bitmap, width, height, color, bg) {
    for(var y = 0; y <= bitmap.length/height+1; y++) {
        for(var x = 0; x <= width-1; x++) {
            if(bitmap[x+y*width]==1)
                drawPixel(x+x0, y+y0, color);
              Severity: Minor
              Found in laboite/static/js/gfx.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function drawHex has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              function drawHex(x0, y0, hex_bitmap, width, height, color, bg) {
    bitmap = hexToBinary(hex_bitmap);
    for(var y = 0; y <= bitmap.length/height+1; y++) {
        for(var x = 0; x <= width-1; x++) {
            if(bitmap[x+y*width]==1)
              Severity: Minor
              Found in laboite/static/js/gfx.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  for(var y = 0; y <= bitmap.length/height+1; y++) {
        for(var x = 0; x <= width-1; x++) {
            if(bitmap[x+y*width]==1)
                drawPixel(x+x0, y+y0, color);
            else
              Severity: Major
              Found in laboite/static/js/gfx.js and 1 other location - About 4 hrs to fix
              laboite/static/js/gfx.js on lines 63..70

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  for(var y = 0; y <= bitmap.length/height+1; y++) {
        for(var x = 0; x <= width-1; x++) {
            if(bitmap[x+y*width]==1)
                drawPixel(x+x0, y+y0, color);
            else
              Severity: Major
              Found in laboite/static/js/gfx.js and 1 other location - About 4 hrs to fix
              laboite/static/js/gfx.js on lines 51..58

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 117.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function drawFastHLine(x0, y0, width, color) {
    for (var x = x0; x < x0+width; x++)
        drawPixel(x, y0, color);
}
              Severity: Minor
              Found in laboite/static/js/gfx.js and 1 other location - About 30 mins to fix
              laboite/static/js/gfx.js on lines 97..100

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              function drawFastVLine(x0, y0, height, color) {
    for (var y = y0; y < y0+height; y++)
        drawPixel(x0, y, color);
}
              Severity: Minor
              Found in laboite/static/js/gfx.js and 1 other location - About 30 mins to fix
              laboite/static/js/gfx.js on lines 92..95

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status