Sign upLogin

laravel/framework

View on GitHub
Star
src/Illuminate/Bus/Batch.php

Summary

Maintainability
B
5 hrs
Test Coverage

Batch has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class Batch implements Arrayable, JsonSerializable
{
    /**
     * The queue factory implementation.
     *
Severity: Minor
Found in src/Illuminate/Bus/Batch.php - About 2 hrs to fix

    Method __construct has 12 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct(QueueFactory $queue,
                                BatchRepository $repository,
                                string $id,
                                string $name,
                                int $totalJobs,
    Severity: Major
    Found in src/Illuminate/Bus/Batch.php - About 1 hr to fix

      Method add has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function add($jobs)
    {
        $count = 0;

        $jobs = Collection::wrap($jobs)->map(function ($job) use (&$count) {
      Severity: Minor
      Found in src/Illuminate/Bus/Batch.php - About 1 hr to fix

        Function recordSuccessfulJob has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function recordSuccessfulJob(string $jobId)
    {
        $counts = $this->decrementPendingJobs($jobId);

        if ($this->hasProgressCallbacks()) {
        Severity: Minor
        Found in src/Illuminate/Bus/Batch.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status