laravel/framework

View on GitHub
src/Illuminate/Bus/DynamoBatchRepository.php

Summary

Maintainability
D
2 days
Test Coverage

File DynamoBatchRepository.php has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Illuminate\Bus;

use Aws\DynamoDb\DynamoDbClient;
Severity: Minor
Found in src/Illuminate/Bus/DynamoBatchRepository.php - About 3 hrs to fix

    DynamoBatchRepository has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DynamoBatchRepository implements BatchRepository
    {
        /**
         * The batch factory instance.
         *
    Severity: Minor
    Found in src/Illuminate/Bus/DynamoBatchRepository.php - About 2 hrs to fix

      Method createAwsDynamoTable has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createAwsDynamoTable(): void
          {
              $definition = [
                  'TableName' => $this->table,
                  'AttributeDefinitions' => [
      Severity: Minor
      Found in src/Illuminate/Bus/DynamoBatchRepository.php - About 1 hr to fix

        Method find has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function find(string $batchId)
            {
                if ($batchId === '') {
                    return null;
                }
        Severity: Minor
        Found in src/Illuminate/Bus/DynamoBatchRepository.php - About 1 hr to fix

          Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  BatchFactory $factory,
                  DynamoDbClient $dynamoDbClient,
                  string $applicationName,
                  string $table,
                  ?int $ttl,
          Severity: Minor
          Found in src/Illuminate/Bus/DynamoBatchRepository.php - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function cancel(string $batchId)
                {
                    $update = 'SET cancelled_at = :timestamp, finished_at = :timestamp';
            
                    if ($this->ttl !== null) {
            Severity: Major
            Found in src/Illuminate/Bus/DynamoBatchRepository.php and 1 other location - About 4 hrs to fix
            src/Illuminate/Bus/DynamoBatchRepository.php on lines 308..329

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 162.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function markAsFinished(string $batchId)
                {
                    $update = 'SET finished_at = :timestamp';
            
                    if ($this->ttl !== null) {
            Severity: Major
            Found in src/Illuminate/Bus/DynamoBatchRepository.php and 1 other location - About 4 hrs to fix
            src/Illuminate/Bus/DynamoBatchRepository.php on lines 337..358

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 162.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status