Sign upLogin

laravel/framework

View on GitHub
Star
src/Illuminate/Database/Eloquent/Builder.php

Summary

Maintainability
F
6 days
Test Coverage

File Builder.php has 992 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Illuminate\Database\Eloquent;

use BadMethodCallException;
Severity: Major
Found in src/Illuminate/Database/Eloquent/Builder.php - About 2 days to fix

    Builder has 106 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Builder implements BuilderContract
{
    use BuildsQueries, ForwardsCalls, QueriesRelationships {
        BuildsQueries::sole as baseSole;
    }
    Severity: Major
    Found in src/Illuminate/Database/Eloquent/Builder.php - About 2 days to fix

      Function prepareNestedWithRelationships has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function prepareNestedWithRelationships($relations, $prefix = '')
    {
        $preparedRelationships = [];

        if ($prefix !== '') {
      Severity: Minor
      Found in src/Illuminate/Database/Eloquent/Builder.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method prepareNestedWithRelationships has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function prepareNestedWithRelationships($relations, $prefix = '')
    {
        $preparedRelationships = [];

        if ($prefix !== '') {
      Severity: Minor
      Found in src/Illuminate/Database/Eloquent/Builder.php - About 1 hr to fix

        Function whereKey has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function whereKey($id)
    {
        if ($id instanceof Model) {
            $id = $id->getKey();
        }
        Severity: Minor
        Found in src/Illuminate/Database/Eloquent/Builder.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function whereKeyNot has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function whereKeyNot($id)
    {
        if ($id instanceof Model) {
            $id = $id->getKey();
        }
        Severity: Minor
        Found in src/Illuminate/Database/Eloquent/Builder.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method paginate has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function paginate($perPage = null, $columns = ['*'], $pageName = 'page', $page = null, $total = null)
        Severity: Minor
        Found in src/Illuminate/Database/Eloquent/Builder.php - About 35 mins to fix

          Function __call has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __call($method, $parameters)
    {
        if ($method === 'macro') {
            $this->localMacros[$parameters[0]] = $parameters[1];
          Severity: Minor
          Found in src/Illuminate/Database/Eloquent/Builder.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function addUniqueIdsToUpsertValues has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function addUniqueIdsToUpsertValues(array $values)
    {
        if (! $this->model->usesUniqueIds()) {
            return $values;
        }
          Severity: Minor
          Found in src/Illuminate/Database/Eloquent/Builder.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return $this->toBase()->{$method}(...$parameters);
          Severity: Major
          Found in src/Illuminate/Database/Eloquent/Builder.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $this;
            Severity: Major
            Found in src/Illuminate/Database/Eloquent/Builder.php - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function whereKey($id)
    {
        if ($id instanceof Model) {
            $id = $id->getKey();
        }
              Severity: Major
              Found in src/Illuminate/Database/Eloquent/Builder.php and 1 other location - About 4 hrs to fix
              src/Illuminate/Database/Eloquent/Builder.php on lines 272..293

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 174.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function whereKeyNot($id)
    {
        if ($id instanceof Model) {
            $id = $id->getKey();
        }
              Severity: Major
              Found in src/Illuminate/Database/Eloquent/Builder.php and 1 other location - About 4 hrs to fix
              src/Illuminate/Database/Eloquent/Builder.php on lines 243..264

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 174.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function findOr($id, $columns = ['*'], ?Closure $callback = null)
    {
        if ($columns instanceof Closure) {
            $callback = $columns;
              Severity: Minor
              Found in src/Illuminate/Database/Eloquent/Builder.php and 1 other location - About 45 mins to fix
              src/Illuminate/Database/Query/Builder.php on lines 2852..2865

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 96.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status