Sign upLogin

laravel/framework

View on GitHub
Star
src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php

Summary

Maintainability
D
2 days
Test Coverage

File QueriesRelationships.php has 411 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Illuminate\Database\Eloquent\Concerns;

use BadMethodCallException;
Severity: Minor
Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 5 hrs to fix

    Function withAggregate has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function withAggregate($relations, $column, $function = null)
    {
        if (empty($relations)) {
            return $this;
        }
    Severity: Minor
    Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method withAggregate has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function withAggregate($relations, $column, $function = null)
    {
        if (empty($relations)) {
            return $this;
        }
    Severity: Major
    Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 2 hrs to fix

      Method hasMorph has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function hasMorph($relation, $types, $operator = '>=', $count = 1, $boolean = 'and', ?Closure $callback = null)
    {
        if (is_string($relation)) {
            $relation = $this->getRelationWithoutConstraints($relation);
        }
      Severity: Minor
      Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 1 hr to fix

        Method whereBelongsTo has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function whereBelongsTo($related, $relationshipName = null, $boolean = 'and')
    {
        if (! $related instanceof Collection) {
            $relatedCollection = $related->newCollection([$related]);
        } else {
        Severity: Minor
        Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 1 hr to fix

          Method hasMorph has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function hasMorph($relation, $types, $operator = '>=', $count = 1, $boolean = 'and', ?Closure $callback = null)
          Severity: Minor
          Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 45 mins to fix

            Method orWhereHasMorph has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function orWhereHasMorph($relation, $types, ?Closure $callback = null, $operator = '>=', $count = 1)
            Severity: Minor
            Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 35 mins to fix

              Method has has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function has($relation, $operator = '>=', $count = 1, $boolean = 'and', ?Closure $callback = null)
              Severity: Minor
              Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 35 mins to fix

                Method addHasWhere has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    protected function addHasWhere(Builder $hasQuery, Relation $relation, $operator, $count, $boolean)
                Severity: Minor
                Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 35 mins to fix

                  Method orWhereMorphRelation has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function orWhereMorphRelation($relation, $types, $column, $operator = null, $value = null)
                  Severity: Minor
                  Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 35 mins to fix

                    Method whereMorphRelation has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function whereMorphRelation($relation, $types, $column, $operator = null, $value = null)
                    Severity: Minor
                    Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 35 mins to fix

                      Method whereHasMorph has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function whereHasMorph($relation, $types, ?Closure $callback = null, $operator = '>=', $count = 1)
                      Severity: Minor
                      Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 35 mins to fix

                        Method hasNested has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            protected function hasNested($relations, $operator = '>=', $count = 1, $boolean = 'and', $callback = null)
                        Severity: Minor
                        Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 35 mins to fix

                          Function whereBelongsTo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function whereBelongsTo($related, $relationshipName = null, $boolean = 'and')
    {
        if (! $related instanceof Collection) {
            $relatedCollection = $related->newCollection([$related]);
        } else {
                          Severity: Minor
                          Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function whereMorphedTo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function whereMorphedTo($relation, $model, $boolean = 'and')
    {
        if (is_string($relation)) {
            $relation = $this->getRelationWithoutConstraints($relation);
        }
                          Severity: Minor
                          Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function whereRelation($relation, $column, $operator = null, $value = null)
    {
        return $this->whereHas($relation, function ($query) use ($column, $operator, $value) {
            if ($column instanceof Closure) {
                $column($query);
                          Severity: Minor
                          Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php and 1 other location - About 45 mins to fix
                          src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php on lines 406..415

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 96.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function orWhereRelation($relation, $column, $operator = null, $value = null)
    {
        return $this->orWhereHas($relation, function ($query) use ($column, $operator, $value) {
            if ($column instanceof Closure) {
                $column($query);
                          Severity: Minor
                          Found in src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php and 1 other location - About 45 mins to fix
                          src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php on lines 386..395

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 96.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status