laravel/framework

View on GitHub
src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php

Summary

Maintainability
D
2 days
Test Coverage

HasManyThrough has 52 functions (exceeds 20 allowed). Consider refactoring.
Open

class HasManyThrough extends Relation
{
    use InteractsWithDictionary;

    /**
Severity: Major
Found in src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php - About 7 hrs to fix

    File HasManyThrough.php has 402 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace Illuminate\Database\Eloquent\Relations;
    
    use Closure;
    Severity: Minor
    Found in src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php - About 5 hrs to fix

      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct(Builder $query, Model $farParent, Model $throughParent, $firstKey, $secondKey, $localKey, $secondLocalKey)
      Severity: Major
      Found in src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php - About 50 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function findOr($id, $columns = ['*'], ?Closure $callback = null)
            {
                if ($columns instanceof Closure) {
                    $callback = $columns;
        
        
        src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php on lines 757..778

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 164.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public function findOrFail($id, $columns = ['*'])
            {
                $result = $this->find($id, $columns);
        
                $id = $id instanceof Arrayable ? $id->toArray() : $id;
        src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php on lines 732..747

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 141.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status