laravel/framework

View on GitHub
src/Illuminate/Database/Query/Grammars/PostgresGrammar.php

Summary

Maintainability
D
2 days
Test Coverage

PostgresGrammar has 37 functions (exceeds 20 allowed). Consider refactoring.
Open

class PostgresGrammar extends Grammar
{
    /**
     * All of the available clause operators.
     *
Severity: Minor
Found in src/Illuminate/Database/Query/Grammars/PostgresGrammar.php - About 4 hrs to fix

    File PostgresGrammar.php has 359 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace Illuminate\Database\Query\Grammars;
    
    use Illuminate\Database\Query\Builder;
    Severity: Minor
    Found in src/Illuminate/Database/Query/Grammars/PostgresGrammar.php - About 4 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          public function compileUpsert(Builder $query, array $values, array $uniqueBy, array $update)
          {
              $sql = $this->compileInsert($query, $values);
      
              $sql .= ' on conflict ('.$this->columnize($uniqueBy).') do update set ';
      Severity: Major
      Found in src/Illuminate/Database/Query/Grammars/PostgresGrammar.php and 1 other location - About 4 hrs to fix
      src/Illuminate/Database/Query/Grammars/SQLiteGrammar.php on lines 278..291

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 175.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function compileUpdateWithJoinsOrLimit(Builder $query, array $values)
          {
              $table = $this->wrapTable($query->from);
      
              $columns = $this->compileUpdateColumns($query, $values);
      Severity: Major
      Found in src/Illuminate/Database/Query/Grammars/PostgresGrammar.php and 1 other location - About 1 hr to fix
      src/Illuminate/Database/Query/Grammars/SQLiteGrammar.php on lines 331..342

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          protected $operators = [
              '=', '<', '>', '<=', '>=', '<>', '!=',
              'like', 'not like', 'between', 'ilike', 'not ilike',
              '~', '&', '|', '#', '<<', '>>', '<<=', '>>=',
              '&&', '@>', '<@', '?', '?|', '?&', '||', '-', '@?', '@@', '#-',
      Severity: Major
      Found in src/Illuminate/Database/Query/Grammars/PostgresGrammar.php and 1 other location - About 1 hr to fix
      src/Illuminate/Database/Query/Builder.php on lines 223..230

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 106.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function whereBitwise(Builder $query, $where)
          {
              $value = $this->parameter($where['value']);
      
              $operator = str_replace('?', '??', $where['operator']);
      Severity: Minor
      Found in src/Illuminate/Database/Query/Grammars/PostgresGrammar.php and 1 other location - About 40 mins to fix
      src/Illuminate/Database/Query/Grammars/SqlServerGrammar.php on lines 127..134

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function compileDeleteWithJoinsOrLimit(Builder $query)
          {
              $table = $this->wrapTable($query->from);
      
              $alias = last(preg_split('/\s+as\s+/i', $query->from));
      Severity: Minor
      Found in src/Illuminate/Database/Query/Grammars/PostgresGrammar.php and 1 other location - About 35 mins to fix
      src/Illuminate/Database/Query/Grammars/SQLiteGrammar.php on lines 389..398

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 92.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status