laravel/framework

View on GitHub
src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php

Summary

Maintainability
F
3 days
Test Coverage

MySqlGrammar has 87 functions (exceeds 20 allowed). Consider refactoring.
Open

class MySqlGrammar extends Grammar
{
    /**
     * The possible column modifiers.
     *
Severity: Major
Found in src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php - About 1 day to fix

    File MySqlGrammar.php has 607 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace Illuminate\Database\Schema\Grammars;
    
    use Illuminate\Database\Connection;
    Severity: Major
    Found in src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php - About 1 day to fix

      Method compileLegacyRenameColumn has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function compileLegacyRenameColumn(Blueprint $blueprint, Fluent $command, Connection $connection)
          {
              $column = collect($connection->getSchemaBuilder()->getColumns($blueprint->getTable()))
                  ->firstWhere('name', $command->from);
      
      
      Severity: Minor
      Found in src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            protected function modifyVirtualAs(Blueprint $blueprint, Fluent $column)
            {
                if (! is_null($virtualAs = $column->virtualAsJson)) {
                    if ($this->isJsonSelector($virtualAs)) {
                        $virtualAs = $this->wrapJsonSelector($virtualAs);
        Severity: Major
        Found in src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php and 2 other locations - About 1 hr to fix
        src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php on lines 1137..1150
        src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php on lines 980..993

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            protected function modifyStoredAs(Blueprint $blueprint, Fluent $column)
            {
                if (! is_null($storedAs = $column->storedAsJson)) {
                    if ($this->isJsonSelector($storedAs)) {
                        $storedAs = $this->wrapJsonSelector($storedAs);
        Severity: Major
        Found in src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php and 2 other locations - About 1 hr to fix
        src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php on lines 1115..1128
        src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php on lines 980..993

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            protected function modifyNullable(Blueprint $blueprint, Fluent $column)
            {
                if (is_null($column->virtualAs) &&
                    is_null($column->virtualAsJson) &&
                    is_null($column->storedAs) &&
        Severity: Minor
        Found in src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php and 1 other location - About 55 mins to fix
        src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php on lines 1024..1036

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 99.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            protected function typeDateTime(Fluent $column)
            {
                $current = $column->precision ? "CURRENT_TIMESTAMP($column->precision)" : 'CURRENT_TIMESTAMP';
        
                if ($column->useCurrent) {
        Severity: Minor
        Found in src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php and 1 other location - About 45 mins to fix
        src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php on lines 975..988

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            protected function typeTimestamp(Fluent $column)
            {
                $current = $column->precision ? "CURRENT_TIMESTAMP($column->precision)" : 'CURRENT_TIMESTAMP';
        
                if ($column->useCurrent) {
        Severity: Minor
        Found in src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php and 1 other location - About 45 mins to fix
        src/Illuminate/Database/Schema/Grammars/MySqlGrammar.php on lines 921..934

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 95.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status