laravel/framework

View on GitHub
src/Illuminate/Foundation/Configuration/ApplicationBuilder.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method withRouting has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function withRouting(?Closure $using = null,
        ?string $web = null,
        ?string $api = null,
        ?string $commands = null,
        ?string $channels = null,
Severity: Major
Found in src/Illuminate/Foundation/Configuration/ApplicationBuilder.php - About 1 hr to fix

    Method buildRoutingCallback has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected function buildRoutingCallback(?string $web,
            ?string $api,
            ?string $pages,
            ?string $health,
            string $apiPrefix,
    Severity: Minor
    Found in src/Illuminate/Foundation/Configuration/ApplicationBuilder.php - About 45 mins to fix

      Consider simplifying this complex logical expression.
      Open

              if (is_null($using) && (is_string($web) || is_string($api) || is_string($pages) || is_string($health)) || is_callable($then)) {
                  $using = $this->buildRoutingCallback($web, $api, $pages, $health, $apiPrefix, $then);
              }
      Severity: Major
      Found in src/Illuminate/Foundation/Configuration/ApplicationBuilder.php - About 40 mins to fix

        Function buildRoutingCallback has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function buildRoutingCallback(?string $web,
                ?string $api,
                ?string $pages,
                ?string $health,
                string $apiPrefix,
        Severity: Minor
        Found in src/Illuminate/Foundation/Configuration/ApplicationBuilder.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function withRouting has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function withRouting(?Closure $using = null,
                ?string $web = null,
                ?string $api = null,
                ?string $commands = null,
                ?string $channels = null,
        Severity: Minor
        Found in src/Illuminate/Foundation/Configuration/ApplicationBuilder.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status