Sign upLogin

laravel/framework

View on GitHub
Star
src/Illuminate/Routing/Router.php

Summary

Maintainability
F
3 days
Test Coverage

Router has 89 functions (exceeds 20 allowed). Consider refactoring.
Open

class Router implements BindingRegistrar, RegistrarContract
{
    use Macroable {
        __call as macroCall;
    }
Severity: Major
Found in src/Illuminate/Routing/Router.php - About 1 day to fix

    File Router.php has 651 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Illuminate\Routing;

use ArrayObject;
    Severity: Major
    Found in src/Illuminate/Routing/Router.php - About 1 day to fix

      Consider simplifying this complex logical expression.
      Open

              if ($response instanceof PsrResponseInterface) {
            $response = (new HttpFoundationFactory)->createResponse($response);
        } elseif ($response instanceof Model && $response->wasRecentlyCreated) {
            $response = new JsonResponse($response, 201);
        } elseif ($response instanceof Stringable) {
      Severity: Critical
      Found in src/Illuminate/Routing/Router.php - About 1 hr to fix

        Function toResponse has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function toResponse($request, $response)
    {
        if ($response instanceof Responsable) {
            $response = $response->toResponse($request);
        }
        Severity: Minor
        Found in src/Illuminate/Routing/Router.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method view has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function view($uri, $view, $data = [], $status = 200, array $headers = [])
        Severity: Minor
        Found in src/Illuminate/Routing/Router.php - About 35 mins to fix

          Avoid too many return statements within this method.
          Open

                          return true;
          Severity: Major
          Found in src/Illuminate/Routing/Router.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return false;
            Severity: Major
            Found in src/Illuminate/Routing/Router.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return $this->sortMiddleware($middleware);
              Severity: Major
              Found in src/Illuminate/Routing/Router.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return collect($excluded)->contains(
                fn ($exclude) => class_exists($exclude) && $reflection->isSubclassOf($exclude)
            );
                Severity: Major
                Found in src/Illuminate/Routing/Router.php - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function singleton($name, $controller, array $options = [])
    {
        if ($this->container && $this->container->bound(ResourceRegistrar::class)) {
            $registrar = $this->container->make(ResourceRegistrar::class);
        } else {
                  Severity: Minor
                  Found in src/Illuminate/Routing/Router.php and 1 other location - About 45 mins to fix
                  src/Illuminate/Routing/Router.php on lines 332..343

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 95.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function resource($name, $controller, array $options = [])
    {
        if ($this->container && $this->container->bound(ResourceRegistrar::class)) {
            $registrar = $this->container->make(ResourceRegistrar::class);
        } else {
                  Severity: Minor
                  Found in src/Illuminate/Routing/Router.php and 1 other location - About 45 mins to fix
                  src/Illuminate/Routing/Router.php on lines 402..413

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 95.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status