laravel/framework

View on GitHub
src/Illuminate/Support/Testing/Fakes/BusFake.php

Summary

Maintainability
D
2 days
Test Coverage

BusFake has 46 functions (exceeds 20 allowed). Consider refactoring.
Open

class BusFake implements Fake, QueueingDispatcher
{
    use ReflectsClosures;

    /**
Severity: Minor
Found in src/Illuminate/Support/Testing/Fakes/BusFake.php - About 6 hrs to fix

    File BusFake.php has 414 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace Illuminate\Support\Testing\Fakes;
    
    use Closure;
    Severity: Minor
    Found in src/Illuminate/Support/Testing/Fakes/BusFake.php - About 5 hrs to fix

      Method assertDispatchedWithChainOfObjects has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function assertDispatchedWithChainOfObjects($command, $expectedChain, $callback)
          {
              $chain = $expectedChain;
      
              PHPUnit::assertTrue(
      Severity: Minor
      Found in src/Illuminate/Support/Testing/Fakes/BusFake.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                                return false;
        Severity: Major
        Found in src/Illuminate/Support/Testing/Fakes/BusFake.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return true;
          Severity: Major
          Found in src/Illuminate/Support/Testing/Fakes/BusFake.php - About 30 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public function assertDispatchedSync($command, $callback = null)
                {
                    if ($command instanceof Closure) {
                        [$command, $callback] = [$this->firstClosureParameterType($command), $command];
                    }
            Severity: Major
            Found in src/Illuminate/Support/Testing/Fakes/BusFake.php and 3 other locations - About 1 hr to fix
            src/Illuminate/Support/Testing/Fakes/BusFake.php on lines 264..278
            src/Illuminate/Support/Testing/Fakes/EventFake.php on lines 134..148
            src/Illuminate/Support/Testing/Fakes/QueueFake.php on lines 90..104

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 111.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public function assertDispatchedAfterResponse($command, $callback = null)
                {
                    if ($command instanceof Closure) {
                        [$command, $callback] = [$this->firstClosureParameterType($command), $command];
                    }
            Severity: Major
            Found in src/Illuminate/Support/Testing/Fakes/BusFake.php and 3 other locations - About 1 hr to fix
            src/Illuminate/Support/Testing/Fakes/BusFake.php on lines 199..213
            src/Illuminate/Support/Testing/Fakes/EventFake.php on lines 134..148
            src/Illuminate/Support/Testing/Fakes/QueueFake.php on lines 90..104

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 111.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function assertDispatchedAfterResponseTimes($command, $times = 1)
                {
                    $callback = null;
            
                    if ($command instanceof Closure) {
            Severity: Major
            Found in src/Illuminate/Support/Testing/Fakes/BusFake.php and 1 other location - About 1 hr to fix
            src/Illuminate/Support/Testing/Fakes/BusFake.php on lines 222..236

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function assertDispatchedSyncTimes($command, $times = 1)
                {
                    $callback = null;
            
                    if ($command instanceof Closure) {
            Severity: Major
            Found in src/Illuminate/Support/Testing/Fakes/BusFake.php and 1 other location - About 1 hr to fix
            src/Illuminate/Support/Testing/Fakes/BusFake.php on lines 287..301

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public function dispatchedAfterResponse(string $command, $callback = null)
                {
                    if (! $this->hasDispatchedAfterResponse($command)) {
                        return collect();
                    }
            Severity: Major
            Found in src/Illuminate/Support/Testing/Fakes/BusFake.php and 3 other locations - About 30 mins to fix
            src/Illuminate/Support/Testing/Fakes/BusFake.php on lines 507..516
            src/Illuminate/Support/Testing/Fakes/BusFake.php on lines 525..534
            src/Illuminate/Support/Testing/Fakes/EventFake.php on lines 208..219

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public function dispatchedSync(string $command, $callback = null)
                {
                    if (! $this->hasDispatchedSync($command)) {
                        return collect();
                    }
            Severity: Major
            Found in src/Illuminate/Support/Testing/Fakes/BusFake.php and 3 other locations - About 30 mins to fix
            src/Illuminate/Support/Testing/Fakes/BusFake.php on lines 507..516
            src/Illuminate/Support/Testing/Fakes/BusFake.php on lines 543..552
            src/Illuminate/Support/Testing/Fakes/EventFake.php on lines 208..219

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                public function dispatched($command, $callback = null)
                {
                    if (! $this->hasDispatched($command)) {
                        return collect();
                    }
            Severity: Major
            Found in src/Illuminate/Support/Testing/Fakes/BusFake.php and 3 other locations - About 30 mins to fix
            src/Illuminate/Support/Testing/Fakes/BusFake.php on lines 525..534
            src/Illuminate/Support/Testing/Fakes/BusFake.php on lines 543..552
            src/Illuminate/Support/Testing/Fakes/EventFake.php on lines 208..219

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 91.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status