larsvanbraam/transition-controller

View on GitHub
src/lib/AbstractTransitionController.ts

Summary

Maintainability
F
3 days
Test Coverage

File AbstractTransitionController.ts has 360 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { TimelineMax, Animation } from 'gsap';
import EventDispatcher from 'seng-event';
import TransitionEvent from './event/TransitionEvent';
import { IAbstractTransitionControllerOptions } from './interface/IAbstractTranstitionControllerOptions';
import { clearTimeline, cloneTimeline, createTimeline } from './util/TimelineUtils';
Severity: Minor
Found in src/lib/AbstractTransitionController.ts - About 4 hrs to fix

    Function transitionIn has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public transitionIn(forceTransition: boolean = false): Promise<void> {
        let oldTransitionPromise = Promise.resolve();
    
        /**
         * Check if we already have a transition out going on, if so we finish it right away! and trigger a
    Severity: Major
    Found in src/lib/AbstractTransitionController.ts - About 2 hrs to fix

      Function transitionOut has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public transitionOut(
          forceTransition: boolean = false,
          id: string = this.options.transitionOutId,
          reset: boolean = false,
        ): Promise<void> {
      Severity: Major
      Found in src/lib/AbstractTransitionController.ts - About 2 hrs to fix

        Function setupTimeline has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public setupTimeline(type: TimelineType, reset: boolean = true, id?: string) {
            let timeline;
            let transitionId;
            let setupMethod;
        
        
        Severity: Minor
        Found in src/lib/AbstractTransitionController.ts - About 1 hr to fix

          Function setupTimeline has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            public setupTimeline(type: TimelineType, reset: boolean = true, id?: string) {
              let timeline;
              let transitionId;
              let setupMethod;
          
          
          Severity: Minor
          Found in src/lib/AbstractTransitionController.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function transitionIn has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            public transitionIn(forceTransition: boolean = false): Promise<void> {
              let oldTransitionPromise = Promise.resolve();
          
              /**
               * Check if we already have a transition out going on, if so we finish it right away! and trigger a
          Severity: Minor
          Found in src/lib/AbstractTransitionController.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handleTransitionComplete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            private handleTransitionComplete(direction: TransitionDirection): void {
              switch (direction) {
                case TransitionDirection.IN:
                  this.transitionInPromise = null;
                  if (this.transitionInResolveMethod !== null) {
          Severity: Minor
          Found in src/lib/AbstractTransitionController.ts - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function transitionOut has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            public transitionOut(
              forceTransition: boolean = false,
              id: string = this.options.transitionOutId,
              reset: boolean = false,
            ): Promise<void> {
          Severity: Minor
          Found in src/lib/AbstractTransitionController.ts - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          TODO found
          Open

                  // TODO: should the forced out wait for the original animation to be completed??

          TODO found
          Open

                  // TODO: should the forced out wait for the original animation to be completed??

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (this.transitionInPromise !== null && forceTransition) {
                  /* istanbul ignore if */
                  if (this.options.debug) {
                    console.warn(`[TransitionController][${
                      this.options.name
          Severity: Major
          Found in src/lib/AbstractTransitionController.ts and 1 other location - About 1 hr to fix
          src/lib/AbstractTransitionController.ts on lines 311..323

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 74.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                if (this._transitionOutPromise !== null && forceTransition) {
                  /* istanbul ignore if */
                  if (this.options.debug) {
                    console.warn(`[TransitionController][${
                      this.options.name
          Severity: Major
          Found in src/lib/AbstractTransitionController.ts and 1 other location - About 1 hr to fix
          src/lib/AbstractTransitionController.ts on lines 206..218

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 74.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                case TimelineType.IN:
                  timeline = this.transitionInTimeline;
                  transitionId = id === void 0 ? this.options.transitionInId : id;
                  setupMethod = this.setupTransitionInTimeline.bind(this);
                  break;
          Severity: Major
          Found in src/lib/AbstractTransitionController.ts and 2 other locations - About 1 hr to fix
          src/lib/AbstractTransitionController.ts on lines 450..454
          src/lib/AbstractTransitionController.ts on lines 455..459

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                case TimelineType.OUT:
                  timeline = this.transitionOutTimeline;
                  transitionId = id === void 0 ? this.options.transitionOutId : id;
                  setupMethod = this.setupTransitionOutTimeline.bind(this);
                  break;
          Severity: Major
          Found in src/lib/AbstractTransitionController.ts and 2 other locations - About 1 hr to fix
          src/lib/AbstractTransitionController.ts on lines 445..449
          src/lib/AbstractTransitionController.ts on lines 455..459

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                case TimelineType.LOOPING:
                  timeline = this.loopingAnimationTimeline;
                  transitionId = id === void 0 ? this.options.loopId : id;
                  setupMethod = this.setupLoopingAnimationTimeline.bind(this);
                  break;
          Severity: Major
          Found in src/lib/AbstractTransitionController.ts and 2 other locations - About 1 hr to fix
          src/lib/AbstractTransitionController.ts on lines 445..449
          src/lib/AbstractTransitionController.ts on lines 450..454

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                case TransitionDirection.IN:
                  if (!this.isDisposed()) {
                    this.dispatchEvent(new TransitionEvent(TransitionEvent.types.TRANSITION_IN_START));
                  }
                  this.isHidden = false;
          Severity: Major
          Found in src/lib/AbstractTransitionController.ts and 1 other location - About 1 hr to fix
          src/lib/AbstractTransitionController.ts on lines 640..645

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                case TransitionDirection.OUT:
                  if (!this.isDisposed()) {
                    this.dispatchEvent(new TransitionEvent(TransitionEvent.types.TRANSITION_OUT_START));
                  }
                  this.isHidden = true;
          Severity: Major
          Found in src/lib/AbstractTransitionController.ts and 1 other location - About 1 hr to fix
          src/lib/AbstractTransitionController.ts on lines 634..639

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (this.transitionOutTimeline.getChildren().length > 0) {
                        this.transitionOutTimeline.restart();
                      } else {
                        this.transitionInTimeline.reverse();
                      }
          Severity: Major
          Found in src/lib/AbstractTransitionController.ts and 1 other location - About 1 hr to fix
          src/lib/AbstractTransitionController.ts on lines 188..192

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (this.transitionOutTimeline.getChildren().length > 0) {
                    this.transitionOutTimeline.kill();
                  } else {
                    this.transitionInTimeline.kill();
                  }
          Severity: Major
          Found in src/lib/AbstractTransitionController.ts and 1 other location - About 1 hr to fix
          src/lib/AbstractTransitionController.ts on lines 342..346

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (this.options.debug) {
                    console.warn(`${this.options.name} Interrupted the transition in!`);
                  }
          Severity: Minor
          Found in src/lib/AbstractTransitionController.ts and 2 other locations - About 30 mins to fix
          src/lib/AbstractTransitionController.ts on lines 196..198
          src/lib/AbstractTransitionController.ts on lines 255..260

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (this.options.debug) {
                    console.warn(`[TransitionController][${
                      this.options.name
                    }] Transition in triggered when it's already 
                    visible, so we will do nothing and return a resolved promise!`);
          Severity: Minor
          Found in src/lib/AbstractTransitionController.ts and 2 other locations - About 30 mins to fix
          src/lib/AbstractTransitionController.ts on lines 196..198
          src/lib/AbstractTransitionController.ts on lines 301..303

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (this.options.debug) {
                    console.info(`${this.options.name} Interrupted the transition out!`);
                  }
          Severity: Minor
          Found in src/lib/AbstractTransitionController.ts and 2 other locations - About 30 mins to fix
          src/lib/AbstractTransitionController.ts on lines 255..260
          src/lib/AbstractTransitionController.ts on lines 301..303

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status