Sign upLogin

leafygreen/mops-cli

View on GitHub
Star

Showing 7 of 7 total issues

Function writeCSV has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MetricsWriter.prototype.writeCSV = function() {
    var metricNames = Object.keys(this.metrics).sort();
    var minTimestamp;
    var maxTimestamp;
Severity: Major
Found in lib/util/MetricsWriter.js - About 3 hrs to fix

    Function openJSONInEditor has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        openJSONInEditor: function(json) {
        function checksum (str) {
            return crypto
                .createHash('md5')
                .update(str, 'utf8')
    Severity: Minor
    Found in lib/util/editorUtil.js - About 1 hr to fix

      Function getRequiredOptions has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getRequiredOptions: function(schema, cliOptions, mopsConfig) {
        var options = {};
        var deferred = q.defer();
        var properties = Object.keys(schema.properties);
      Severity: Minor
      Found in lib/util/promptUtil.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function getProvisionedMachineDirectory() {
   return /^win/.test(os.platform()) ?
           process.env.HOME + '/_mops_machines/' :
           process.env.HOME + '/.mops_machines/';
}
        Severity: Major
        Found in lib/util/MopsConfig.js and 1 other location - About 1 hr to fix
        lib/util/MopsConfig.js on lines 12..16

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function getDefaultFilename() {
    return /^win/.test(os.platform()) ?
           process.env.HOME + '/_mops_config.json' :
           process.env.HOME + '/.mops_config.json';
}
        Severity: Major
        Found in lib/util/MopsConfig.js and 1 other location - About 1 hr to fix
        lib/util/MopsConfig.js on lines 6..10

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            GroupIdAndProvider: {
        properties: {
            groupId: {
                message: optionDescriptions.GROUP_ID,
                required: true
        Severity: Minor
        Found in lib/schema.js and 1 other location - About 50 mins to fix
        lib/schema.js on lines 51..62

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            Metric: {
        properties: {
            groupId: {
                message: optionDescriptions.GROUP_ID,
                required: true
        Severity: Minor
        Found in lib/schema.js and 1 other location - About 50 mins to fix
        lib/schema.js on lines 91..102

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language