Sign upLogin

leap-protocol/leap-js

View on GitHub
Star
src/typeCodec.js

Summary

Maintainability
F
3 days
Test Coverage

Function encode_types has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

exports.encode_types = function encode_types(item, type) {
  try {
    let value;
    if (type == "u8") {
      integer_validity_check(item);
Severity: Minor
Found in src/typeCodec.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function encode_types has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.encode_types = function encode_types(item, type) {
  try {
    let value;
    if (type == "u8") {
      integer_validity_check(item);
Severity: Major
Found in src/typeCodec.js - About 3 hrs to fix

    Function decode_types has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.decode_types = function decode_types(item, type) {
  try {
    let value;
    if (type == "u8") {
      return decode_unsigned(item, 0xff);
    Severity: Minor
    Found in src/typeCodec.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function decode_types has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.decode_types = function decode_types(item, type) {
  try {
    let value;
    if (type == "u8") {
      return decode_unsigned(item, 0xff);
    Severity: Major
    Found in src/typeCodec.js - About 2 hrs to fix

      Avoid deeply nested control flow statements.
      Open

            if (type.includes(item)) {
        value = type.indexOf(item);
        if (value != undefined) {
          return to_padded_hex_string(value, 2);
        }
      Severity: Major
      Found in src/typeCodec.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

              if (value < type.length) {
        return type[value];
      }
        Severity: Major
        Found in src/typeCodec.js - About 45 mins to fix

          Avoid too many return statements within this function.
          Open

                return (item == true) ? ("1") : ("0");
          Severity: Major
          Found in src/typeCodec.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return null;
            Severity: Major
            Found in src/typeCodec.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return type[value];
              Severity: Major
              Found in src/typeCodec.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return "";
                Severity: Major
                Found in src/typeCodec.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return to_padded_hex_string(value, 8);
                  Severity: Major
                  Found in src/typeCodec.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return value;
                    Severity: Major
                    Found in src/typeCodec.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return to_padded_hex_string(value, 8);
                      Severity: Major
                      Found in src/typeCodec.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                  return to_padded_hex_string(value, 2);
                        Severity: Major
                        Found in src/typeCodec.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return decode_signed(item, 0x100000000);
                          Severity: Major
                          Found in src/typeCodec.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return value;
                            Severity: Major
                            Found in src/typeCodec.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                return "";
                              Severity: Major
                              Found in src/typeCodec.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                      return to_padded_hex_string(value, 4);
                                Severity: Major
                                Found in src/typeCodec.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                        return value;
                                  Severity: Major
                                  Found in src/typeCodec.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                            return "";
                                    Severity: Major
                                    Found in src/typeCodec.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                              return value;
                                      Severity: Major
                                      Found in src/typeCodec.js - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                              return str1 + to_padded_hex_string(value, 8);
                                        Severity: Major
                                        Found in src/typeCodec.js - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                                return "";
                                          Severity: Major
                                          Found in src/typeCodec.js - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                return "";
                                            Severity: Major
                                            Found in src/typeCodec.js - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                    return (item == "1") ? (true) : (false);
                                              Severity: Major
                                              Found in src/typeCodec.js - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                      return decode_signed(item, 0x10000);
                                                Severity: Major
                                                Found in src/typeCodec.js - About 30 mins to fix

                                                  Avoid too many return statements within this function.
                                                  Open

                                                    return null;
                                                  Severity: Major
                                                  Found in src/typeCodec.js - About 30 mins to fix

                                                    Function decode_signed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                                    Open

                                                    function decode_signed(item, capacity) {
  let reHex = /^[\dA-Fa-f]{1,}$/;

  if (reHex.test(item) == true) {
    let value = parseInt(item, 16);
                                                    Severity: Minor
                                                    Found in src/typeCodec.js - About 25 mins to fix

                                                    Cognitive Complexity

                                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                    A method's cognitive complexity is based on a few simple rules:

                                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                    • Code is considered more complex for each "break in the linear flow of the code"
                                                    • Code is considered more complex when "flow breaking structures are nested"

                                                    Further reading

                                                    Similar blocks of code found in 3 locations. Consider refactoring.
                                                    Open

                                                        else if (type == "i8") {
      integer_validity_check(item);
      value = clamp(item, -0x80, 0x7F);
      value = (value < 0) ? (value + 0x100) : (value);
      return to_padded_hex_string(value, 2);
                                                    Severity: Major
                                                    Found in src/typeCodec.js and 2 other locations - About 1 hr to fix
                                                    src/typeCodec.js on lines 39..91
                                                    src/typeCodec.js on lines 45..91

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 55.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    Similar blocks of code found in 3 locations. Consider refactoring.
                                                    Open

                                                        else if (type == "i16") {
      integer_validity_check(item);
      value = clamp(item, -0x8000, 0x7FFF);
      value = (value < 0) ? (value + 0x10000) : (value);
      return to_padded_hex_string(value, 4);
                                                    Severity: Major
                                                    Found in src/typeCodec.js and 2 other locations - About 1 hr to fix
                                                    src/typeCodec.js on lines 33..91
                                                    src/typeCodec.js on lines 45..91

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 55.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    Similar blocks of code found in 3 locations. Consider refactoring.
                                                    Open

                                                        else if (type == "i32") {
      integer_validity_check(item);
      value = clamp(item, -0x80000000, 0x7FFFFFFF);
      value = (value < 0) ? (value + 0x100000000) : (value);
      return to_padded_hex_string(value, 8);
                                                    Severity: Major
                                                    Found in src/typeCodec.js and 2 other locations - About 1 hr to fix
                                                    src/typeCodec.js on lines 33..91
                                                    src/typeCodec.js on lines 39..91

                                                    Duplicated Code

                                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                    Tuning

                                                    This issue has a mass of 55.

                                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                    Refactorings

                                                    Further Reading

                                                    There are no issues that match your filters.

                                                    Category
                                                    Status