Sign upLogin

leap-protocol/leap-js

View on GitHub
Star

Showing 64 of 64 total issues

Function encode_types has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

exports.encode_types = function encode_types(item, type) {
  try {
    let value;
    if (type == "u8") {
      integer_validity_check(item);
Severity: Minor
Found in src/typeCodec.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function verify_values has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  verify_values(values, branch) {
    const depth = (branch.match(/\//) || []).length;
    if (typeof values !== "object") {
      this.failure = `value of ${branch} must be an object`;
    }
Severity: Minor
Found in src/configDataVerifier.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function encode_types has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.encode_types = function encode_types(item, type) {
  try {
    let value;
    if (type == "u8") {
      integer_validity_check(item);
Severity: Major
Found in src/typeCodec.js - About 3 hrs to fix

    Function decode_types has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.decode_types = function decode_types(item, type) {
  try {
    let value;
    if (type == "u8") {
      return decode_unsigned(item, 0xff);
    Severity: Minor
    Found in src/typeCodec.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generate_maps has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.generate_maps = function generate_maps(protocol_root) {
  const branches = explore.extract_branches(protocol_root, []);
  const addr_path = [];
  const roots = [];
  const encode_map = {};
    Severity: Minor
    Found in src/mapGenerator.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function count_to_path has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.count_to_path = function count_to_path(root, path) {
  let data;
  if ((protocolKey.DATA in root) == false) {
    return null;
  }
    Severity: Minor
    Found in src/explore.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function decode_types has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.decode_types = function decode_types(item, type) {
  try {
    let value;
    if (type == "u8") {
      return decode_unsigned(item, 0xff);
    Severity: Major
    Found in src/typeCodec.js - About 2 hrs to fix

      Function generate_maps has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.generate_maps = function generate_maps(protocol_root) {
  const branches = explore.extract_branches(protocol_root, []);
  const addr_path = [];
  const roots = [];
  const encode_map = {};
      Severity: Major
      Found in src/mapGenerator.js - About 2 hrs to fix

        Function extract_decendants has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.extract_decendants = function extract_decendants(root, path) {
  const decendants = [];
  const start = exports.get_struct(root, path);
  if (start != null) {
    if (protocolKey.DATA in start) {
        Severity: Minor
        Found in src/explore.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function extract_branches has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.extract_branches = function extract_branches(root, path) {
  const start = exports.get_struct(root, path);
  const branches = [];
  if (start != null) {
    if (protocolKey.DATA in start) {
        Severity: Minor
        Found in src/explore.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function count_to_path has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.count_to_path = function count_to_path(root, path) {
  let data;
  if ((protocolKey.DATA in root) == false) {
    return null;
  }
        Severity: Minor
        Found in src/explore.js - About 1 hr to fix

          Function verify_category has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            verify_category(config) {
    if (("category" in config) == false) {
      this.failure = "Missing category key in root data structure";
      return false;
    }
          Severity: Minor
          Found in src/configVerifier.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function get_next_address has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            get_next_address(addr, depth) {
    let next_addr;
    if (addr == null) {
      if (this.current_addr == null) {
        next_addr = 0;
          Severity: Minor
          Found in src/configDataVerifier.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function verify_version has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            verify_version(config) {
    if (("version" in config) == false) {
      this.failure = "Missing version key in root data structure";
    }
    else {
          Severity: Minor
          Found in src/configVerifier.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function verify_category has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            verify_category(config) {
    if (("category" in config) == false) {
      this.failure = "Missing category key in root data structure";
      return false;
    }
          Severity: Minor
          Found in src/configVerifier.js - About 1 hr to fix

            Function _encode_packet has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              _encode_packet(_packet) {
    let internal = "";
    const start = this._config["category"][_packet.category];

    if ((_packet.category in this._config.category) === false) {
            Severity: Minor
            Found in src/codec.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_struct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

            exports.get_struct = function get_struct(root, path) {
  if (path.length === 0) {
    return root;
  }
            Severity: Minor
            Found in src/explore.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function verify_values has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              verify_values(values, branch) {
    const depth = (branch.match(/\//) || []).length;
    if (typeof values !== "object") {
      this.failure = `value of ${branch} must be an object`;
    }
            Severity: Minor
            Found in src/configDataVerifier.js - About 1 hr to fix

              Function get_next_address has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                get_next_address(addr, depth) {
    let next_addr;
    if (addr == null) {
      if (this.current_addr == null) {
        next_addr = 0;
              Severity: Minor
              Found in src/configDataVerifier.js - About 1 hr to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    else if (type == "i8") {
      integer_validity_check(item);
      value = clamp(item, -0x80, 0x7F);
      value = (value < 0) ? (value + 0x100) : (value);
      return to_padded_hex_string(value, 2);
                Severity: Major
                Found in src/typeCodec.js and 2 other locations - About 1 hr to fix
                src/typeCodec.js on lines 39..91
                src/typeCodec.js on lines 45..91

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language