Sign upLogin

learnery/learnery

View on GitHub
Star

Showing 4 of 4 total issues

Class Event has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Event < ActiveRecord::Base
    # Every event has a name and start time

    validates :name, :starts, :type, :presence => true
    validate :validate_starts_before_it_ends
Severity: Minor
Found in app/models/learnery/event.rb - About 2 hrs to fix

    Method index has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def index
      if params[:past] == "true" then
        @events = Event.past
        render "past"
      else
    Severity: Minor
    Found in app/controllers/learnery/events_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if user.persisted?
      flash.notice = "Signed in with #{user.provider}!"
      if !user.email || "" == user.email
        flash.notice += "\nPlease provide an email adress if you want to receive notifications."
      end
    Severity: Minor
    Found in app/controllers/omniauth_callbacks_controller.rb and 1 other location - About 30 mins to fix
    app/controllers/learnery/omniauth_callbacks_controller.rb on lines 6..14

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if user.persisted?
      flash.notice = "Signed in with #{user.provider}!"
      if !user.email || "" == user.email
        flash.notice += "\nPlease provide an email adress if you want to receive notifications."
      end
    Severity: Minor
    Found in app/controllers/learnery/omniauth_callbacks_controller.rb and 1 other location - About 30 mins to fix
    app/controllers/omniauth_callbacks_controller.rb on lines 6..14

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language