Sign upLogin

learnery/learnery

View on GitHub
Star

Showing 2 of 4 total issues

Class Event has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Event < ActiveRecord::Base
    # Every event has a name and start time

    validates :name, :starts, :type, :presence => true
    validate :validate_starts_before_it_ends
Severity: Minor
Found in app/models/learnery/event.rb - About 2 hrs to fix

    Method index has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def index
      if params[:past] == "true" then
        @events = Event.past
        render "past"
      else
    Severity: Minor
    Found in app/controllers/learnery/events_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language