Sign upLogin

learningworks/moodle-block_lw_courses

View on GitHub
Star
lib.php

Summary

Maintainability
A
50 mins
Test Coverage

Showing 6 of 6 total issues

Method block_lw_courses_pluginfile has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

function block_lw_courses_pluginfile($course, $birecord, $context, $filearea, $args, $forcedownload, array $options = array()) {
Severity: Major
Found in lib.php - About 50 mins to fix

    Avoid unused parameters such as '$course'.
    Open

    function block_lw_courses_pluginfile($course, $birecord, $context, $filearea, $args, $forcedownload, array $options = array()) {
    Severity: Minor
    Found in lib.php by phpmd

    Avoid unused parameters such as '$options'.
    Open

    function block_lw_courses_pluginfile($course, $birecord, $context, $filearea, $args, $forcedownload, array $options = array()) {
    Severity: Minor
    Found in lib.php by phpmd

    Avoid unused parameters such as '$birecord'.
    Open

    function block_lw_courses_pluginfile($course, $birecord, $context, $filearea, $args, $forcedownload, array $options = array()) {
    Severity: Minor
    Found in lib.php by phpmd

    Avoid unused parameters such as '$filearea'.
    Open

    function block_lw_courses_pluginfile($course, $birecord, $context, $filearea, $args, $forcedownload, array $options = array()) {
    Severity: Minor
    Found in lib.php by phpmd

    Avoid assigning values to variables in if clauses and the like (line '44', column '10').
    Open

    function block_lw_courses_pluginfile($course, $birecord, $context, $filearea, $args, $forcedownload, array $options = array()) {
        $fs = get_file_storage();
     
        $filename = array_pop($args);
        $filepath = $args ? '/'.implode('/', $args).'/' : '/';
    Severity: Minor
    Found in lib.php by phpmd
    Category
    Status