Showing 494 of 494 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

def guess_entity_software(e):
    for elt in chain(e.findall(".//{%s}SingleSignOnService" % NS['md']),
                     e.findall(".//{%s}AssertionConsumerService" % NS['md'])):
        location = elt.get('Location')
        if location:
Severity: Major
Found in src/pyff/samlmd.py and 1 other location - About 4 days to fix
src/pyff/utils.py on lines 599..651

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 432.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

def guess_entity_software(e):
    for elt in chain(e.findall(".//{%s}SingleSignOnService" % NS['md']),
                     e.findall(".//{%s}AssertionConsumerService" % NS['md'])):
        location = elt.get('Location')
        if location:
Severity: Major
Found in src/pyff/utils.py and 1 other location - About 4 days to fix
src/pyff/samlmd.py on lines 417..470

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 432.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File builtins.py has 1101 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""
These are the built-in "pipes" - functions that can be used to put together a processing pipeling for pyFF.
"""

import base64
Severity: Major
Found in src/pyff/builtins.py - About 2 days to fix

    File samlmd.py has 848 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    from datetime import datetime
    from .utils import parse_xml, check_signature, root, validate_document, xml_error, \
        schema, iso2datetime, duration2timedelta, filter_lang, url2host, trunc_str, subdomains, \
        has_tag, hash_id, load_callable, rreplace, dumptree, first_text, is_text, unicode_stream, \
        Lambda, b2u
    Severity: Major
    Found in src/pyff/samlmd.py - About 2 days to fix

      Function request has a Cognitive Complexity of 88 (exceeds 5 allowed). Consider refactoring.
      Open

          def request(self, **kwargs):
              """The main request processor. This code implements all rendering of metadata.
              """
      
              if not self.ready:
      Severity: Minor
      Found in src/pyff/mdx.py - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File store.py has 743 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import operator
      import re
      
      import ipaddr
      import six
      Severity: Major
      Found in src/pyff/store.py - About 1 day to fix

        File utils.py has 695 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # coding=utf-8
        
        
        """
        
        
        Severity: Major
        Found in src/pyff/utils.py - About 1 day to fix

          File mdx.py has 647 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          """
          An implementation of draft-lajoie-md-query
          
          .. code-block:: bash
          
          
          Severity: Major
          Found in src/pyff/mdx.py - About 1 day to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    def _strings(elt):
                        lst = []
                        for attr in ['{%s}DisplayName' % NS['mdui'],
                                     '{%s}ServiceName' % NS['md'],
                                     '{%s}OrganizationDisplayName' % NS['md'],
            Severity: Major
            Found in src/pyff/builtins.py and 1 other location - About 1 day to fix
            src/pyff/store.py on lines 387..397

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 155.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    def _strings(elt):
                        lst = []
                        for attr in ['{%s}DisplayName' % NS['mdui'],
                                     '{%s}ServiceName' % NS['md'],
                                     '{%s}OrganizationDisplayName' % NS['md'],
            Severity: Major
            Found in src/pyff/store.py and 1 other location - About 1 day to fix
            src/pyff/builtins.py on lines 617..627

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 155.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if len(args) > 0 and args[0] in self.server.aliases:
                        kwargs['pfx'] = args[0]
                        if len(args) > 1:
                            kwargs['path'] = args[1]
                        return self.server.request(**kwargs)
            Severity: Major
            Found in src/pyff/mdx.py and 1 other location - About 1 day to fix
            src/pyff/mdx.py on lines 415..423

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 140.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if len(args) > 0 and args[0] in self.server.aliases:
                        kwargs['pfx'] = args[0]
                        if len(args) > 1:
                            kwargs['path'] = args[1]
                        return self.server.request(**kwargs)
            Severity: Major
            Found in src/pyff/mdx.py and 1 other location - About 1 day to fix
            src/pyff/mdx.py on lines 271..279

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 140.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function select has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
            Open

            def select(req, *opts):
                """
                Select a set of EntityDescriptor elements as the working document.
            
                :param req: The request
            Severity: Minor
            Found in src/pyff/builtins.py - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function search has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
            Open

                def search(self, query=None, path=None, entity_filter=None, related=None):
                    """
            :param query: A string to search for.
            :param path: The repository collection (@Name) to search in - None for search in all collections
            :param entity_filter: An optional lookup expression used to filter the entries before search is done.
            Severity: Minor
            Found in src/pyff/store.py - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function guess_entity_software has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
            Open

            def guess_entity_software(e):
                for elt in chain(e.findall(".//{%s}SingleSignOnService" % NS['md']),
                                 e.findall(".//{%s}AssertionConsumerService" % NS['md'])):
                    location = elt.get('Location')
                    if location:
            Severity: Minor
            Found in src/pyff/utils.py - About 7 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function guess_entity_software has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
            Open

            def guess_entity_software(e):
                for elt in chain(e.findall(".//{%s}SingleSignOnService" % NS['md']),
                                 e.findall(".//{%s}AssertionConsumerService" % NS['md'])):
                    location = elt.get('Location')
                    if location:
            Severity: Minor
            Found in src/pyff/samlmd.py - About 7 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function hex_sha1 has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
            Open

            var hex_sha1 = function () {
            var fromCharCode = String.fromCharCode;
            /*
             * Calculate the SHA1 of a raw string
             */
            Severity: Minor
            Found in src/pyff/site/static/js/sha1.js - About 6 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if xp is None:
                        return l
                    else:
                        log.debug("filtering %d entities using xpath %s" % (len(l), xp))
                        t = entitiesdescriptor(l, 'dummy', lookup_fn=self.lookup)
            Severity: Major
            Found in src/pyff/repo.py and 1 other location - About 6 hrs to fix
            src/pyff/store.py on lines 321..330

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if xp is None:
                        return l
                    else:
                        log.debug("filtering %d entities using xpath %s" % (len(l), xp))
                        t = entitiesdescriptor(l, 'dummy', lookup_fn=self.lookup)
            Severity: Major
            Found in src/pyff/store.py and 1 other location - About 6 hrs to fix
            src/pyff/repo.py on lines 86..95

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Cyclomatic complexity is too high in function guess_entity_software. (35)
            Open

            def guess_entity_software(e):
                for elt in chain(e.findall(".//{%s}SingleSignOnService" % NS['md']),
                                 e.findall(".//{%s}AssertionConsumerService" % NS['md'])):
                    location = elt.get('Location')
                    if location:
            Severity: Minor
            Found in src/pyff/utils.py by radon

            Cyclomatic Complexity

            Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

            Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

            Construct Effect on CC Reasoning
            if +1 An if statement is a single decision.
            elif +1 The elif statement adds another decision.
            else +0 The else statement does not cause a new decision. The decision is at the if.
            for +1 There is a decision at the start of the loop.
            while +1 There is a decision at the while statement.
            except +1 Each except branch adds a new conditional path of execution.
            finally +0 The finally block is unconditionally executed.
            with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
            assert +1 The assert statement internally roughly equals a conditional statement.
            Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
            Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

            Source: http://radon.readthedocs.org/en/latest/intro.html

            Severity
            Category
            Status
            Source
            Language