Showing 150 of 257 total issues

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, request, response, pool, name, content_handler):
Severity: Minor
Found in src/pyff/fetch.py - About 35 mins to fix

    Function discojson has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def discojson(e, sources=None, langs=None, fallback_to_favicon=False, icon_store=None):
    Severity: Minor
    Found in src/pyff/samlmd.py - About 35 mins to fix

      Function i_handle has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def i_handle(self, t: Resource, url=None, response=None, exception=None, last_fetched=None):
      Severity: Minor
      Found in src/pyff/resource.py - About 35 mins to fix

        Function i_handle has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def i_handle(self, t, url=None, response=None, exception=None, last_fetched=None):
        Severity: Minor
        Found in src/pyff/resource.py - About 35 mins to fix

          Function annotate_entity has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def annotate_entity(e, category, title, message, source=None):
          Severity: Minor
          Found in src/pyff/samlmd.py - About 35 mins to fix

            Function i_handle has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def i_handle(self, t, url=None, response=None, exception=None, last_fetched=None):
            Severity: Minor
            Found in src/pyff/resource.py - About 35 mins to fix

              Function short_spec has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def short_spec(self):
                      if self.short:
                          if (hasattr(self, 'typeconv') and self.typeconv == as_bool) or isinstance(self, InvertedSetting):
                              return self.short
                          else:
              Severity: Minor
              Found in src/pyff/constants.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function url_get has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              def url_get(url: str, verify_tls: Optional[bool] = False) -> Response:
                  """
                  Download an URL using a cache and return the response object
                  :param url:
                  :return:
              Severity: Minor
              Found in src/pyff/utils.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function entity_extended_display has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              def entity_extended_display(entity, langs=None):
                  """Utility-method for computing a displayable string for a given entity.
              
                  :param entity: An EntityDescriptor element
                  :param langs: The list of languages to search in priority order
              Severity: Minor
              Found in src/pyff/samlmd.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _any has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              def _any(lst, d):
                  for x in lst:
                      if x in d:
                          if type(d) == dict:
                              return d[x]
              Severity: Minor
              Found in src/pyff/builtins.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function filter_or_validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              def filter_or_validate(
                  t: ElementTree,
                  filter_invalid: bool = False,
                  base_url: str = "",
                  source=None,
              Severity: Minor
              Found in src/pyff/samlmd.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _all_domains_and_subdomains has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              def _all_domains_and_subdomains(entity):
                  dlist = []
                  try:
                      for dn in _domains(entity):
                          for sub in subdomains(dn):
              Severity: Minor
              Found in src/pyff/samlmd.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function filter_lang has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              def filter_lang(elts: Any, langs: Optional[Sequence[str]] = None) -> List[Element]:
                  if langs is None or type(langs) is not list:
                      langs = config.langs
              
                  # log.debug("langs: {}".format(langs))
              Severity: Minor
              Found in src/pyff/utils.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function metadata_expiration has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              def metadata_expiration(t: ElementTree) -> Optional[timedelta]:
                  relt = root(t)
                  if relt.tag in ('{%s}EntityDescriptor' % NS['md'], '{%s}EntitiesDescriptor' % NS['md']):
                      cache_duration = config.default_cache_duration
                      valid_until = relt.get('validUntil', None)
              Severity: Minor
              Found in src/pyff/samlmd.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _select has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def _select(self, member=None):
                      if member is None:
                          member = "entities"
              
                      if is_text(member):
              Severity: Minor
              Found in src/pyff/store.py - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                              return 'SURFConext'
              Severity: Major
              Found in src/pyff/samlmd.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return 'SimpleSAMLphp'
                Severity: Major
                Found in src/pyff/utils.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return entity.get('entityID').strip()
                  Severity: Major
                  Found in src/pyff/samlmd.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return 'OpenAthens'
                    Severity: Major
                    Found in src/pyff/utils.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return 'Authentic2'
                      Severity: Major
                      Found in src/pyff/utils.py - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language