Showing 150 of 257 total issues

Avoid too many return statements within this function.
Open

        return []
Severity: Major
Found in src/pyff/store.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return 'OpenAthens'
    Severity: Major
    Found in src/pyff/samlmd.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return 'OpenAthens'
      Severity: Major
      Found in src/pyff/utils.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return 'PingFederate'
        Severity: Major
        Found in src/pyff/samlmd.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return data
          Severity: Major
          Found in src/pyff/utils.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return 'Salesforce'
            Severity: Major
            Found in src/pyff/utils.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return []
              Severity: Major
              Found in src/pyff/store.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return 'PySAML'
                Severity: Major
                Found in src/pyff/samlmd.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return 'OpenAthens'
                  Severity: Major
                  Found in src/pyff/samlmd.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return 'OpenSSO'
                    Severity: Major
                    Found in src/pyff/utils.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return 'Shibboleth'
                      Severity: Major
                      Found in src/pyff/utils.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return self._lookup("{%s}%s" % (m.group(1), str(m.group(2)).rstrip("/")))
                        Severity: Major
                        Found in src/pyff/store.py - About 30 mins to fix

                          Function parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def parse(self, resource: Resource, content: str) -> ParserInfo:
                                  info = ParserInfo(description='XRD links', expiration_time='never expires')
                                  t = parse_xml(unicode_stream(content))
                          
                                  relt = root(t)
                          Severity: Minor
                          Found in src/pyff/parse.py - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function b2u has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def b2u(data: Union[str, bytes, Tuple, List, Set]) -> Union[str, bytes, Tuple, List, Set]:
                              if is_text(data):
                                  return data
                              elif isinstance(data, six.binary_type):
                                  return data.decode("utf-8")
                          Severity: Minor
                          Found in src/pyff/utils.py - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function json_serializer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def json_serializer(o):
                              if isinstance(o, datetime):
                                  return o.__str__()
                              if isinstance(o, CaseInsensitiveDict):
                                  return dict(o.items())
                          Severity: Minor
                          Found in src/pyff/utils.py - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function search_handler has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def search_handler(request: Request) -> Response:
                              """
                              Implements the /api/search endpoint
                          
                              :param request: the HTTP request with the 'query' request parameter
                          Severity: Minor
                          Found in src/pyff/api.py - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function sub_domains has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def sub_domains(e):
                              lst = []
                              domains = entity_domains(e)
                              for d in domains:
                                  for sub in subdomains(d):
                          Severity: Minor
                          Found in src/pyff/samlmd.py - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function select has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def select(self, member, xp=None):
                                  """
                                  Select a set of metadata elements and return an EntityDescriptor with the result of the select.
                          
                                  :param member: A selector (cf below)
                          Severity: Minor
                          Found in src/pyff/store.py - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function load_requirements has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def load_requirements(path: PurePath) -> List[str]:
                              """ Load dependencies from a requirements.txt style file, ignoring comments etc. """
                              res = []
                              with open(path) as fd:
                                  for line in fd.readlines():
                          Severity: Minor
                          Found in setup.py - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function main has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def main():
                              """
                              The (new) main entrypoint for the pyffd command.
                              """
                              args = parse_options("pyffd", __doc__)
                          Severity: Minor
                          Found in src/pyff/mdq.py - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language