Sign upLogin

lemonphp/json-api

View on GitHub
Star

Showing 11 of 12 total issues

Method resourceProvider has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function resourceProvider()
    {
        return [
            [
                [
Severity: Major
Found in tests/Document/Resource/ResourceTest.php - About 2 hrs to fix

    Method testFromTheReadmeFile has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function testFromTheReadmeFile()
    {
        $json = <<<JSON
{
    "data": {
    Severity: Minor
    Found in tests/IntegrationTest.php - About 1 hr to fix

      Method testIncludedResourcesRepresentedAsArray has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function testIncludedResourcesRepresentedAsArray()
    {
        $apple = new ResourceObject('apples', '1');
        $apple->setAttribute('color', 'red');
        $orange = new ResourceObject('oranges', '1');
      Severity: Minor
      Found in tests/Document/CompoundDocumentTest.php - About 1 hr to fix

        Method testErrorWithFullSetOfProperties has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function testErrorWithFullSetOfProperties()
    {
        $e = new Error();
        $e->setId('test_id');
        $e->setAboutLink('http://localhost');
        Severity: Minor
        Found in tests/Document/ErrorTest.php - About 1 hr to fix

          Function enforceFullLinkage has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function enforceFullLinkage()
    {
        if ($this->isSparse || empty($this->included)) {
            return;
        }
          Severity: Minor
          Found in src/Document.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Missing class import via use statement (line '36', column '22').
          Open

                      [[], new \stdClass()],
          Severity: Minor
          Found in tests/UtitlityTest.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
    return new \stdClass();
}

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Function identifies has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function identifies(ResourceInterface $resource): bool
    {
        if ($this->relationships) {
            /** @var Relationship $relationship */
            foreach ($this->relationships as $relationship) {
          Severity: Minor
          Found in src/Document/Resource/ResourceObject.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid unused parameters such as '$name'.
          Open

              public static function validMemberName($name)
          Severity: Minor
          Found in src/Utility.php by phpmd

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          FIXME found
          Open

              <!-- Required fix all TODO and FIXME markers -->
          Severity: Minor
          Found in phpcs.xml.dist by fixme

          TODO found
          Open

              <!-- Required fix all TODO and FIXME markers -->
          Severity: Minor
          Found in phpcs.xml.dist by fixme

          TODO found
          Open

                  // TODO: implement method
          Severity: Minor
          Found in src/Utility.php by fixme
          Severity
          Category
          Status
          Source
          Language