Sign upLogin

leonitousconforti/tinyburg

View on GitHub
Star
packages/insight/src/agents/get-mission-data.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function transformToSourceCode has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public transformToSourceCode() {
        // Import for the floor type enum
        // eslint-disable-next-line quotes
        const floorTypeEnumImport = 'import { FloorType } from "./floors.js";\n';
Severity: Minor
Found in packages/insight/src/agents/get-mission-data.ts - About 1 hr to fix

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    const rpcExports: IMissionAgentExports = {
    main: async () => {
        const instance = await new GetMissionData().start();
        return instance.transformToSourceCode();
    },
    Severity: Major
    Found in packages/insight/src/agents/get-mission-data.ts and 7 other locations - About 1 hr to fix
    packages/insight/src/agents/get-bitbook-data.ts on lines 85..90
    packages/insight/src/agents/get-bitizen-data.ts on lines 169..174
    packages/insight/src/agents/get-costume-data.ts on lines 54..59
    packages/insight/src/agents/get-elevator-data.ts on lines 73..78
    packages/insight/src/agents/get-floor-data.ts on lines 118..123
    packages/insight/src/agents/get-pet-data.ts on lines 62..67
    packages/insight/src/agents/get-roof-data.ts on lines 68..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

            const version = this.dependencies.AppUtilClass.method<Il2Cpp.String>("VersionString").invoke().content;
    Severity: Major
    Found in packages/insight/src/agents/get-mission-data.ts and 6 other locations - About 40 mins to fix
    packages/insight/src/agents/get-bitbook-data.ts on lines 33..33
    packages/insight/src/agents/get-bitizen-data.ts on lines 41..41
    packages/insight/src/agents/get-costume-data.ts on lines 22..22
    packages/insight/src/agents/get-elevator-data.ts on lines 21..21
    packages/insight/src/agents/get-floor-data.ts on lines 22..22
    packages/insight/src/agents/get-roof-data.ts on lines 21..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status