Sign upLogin

leonitousconforti/tinyburg

View on GitHub
Star
packages/nucleus/src/endpoints/check-for-newer-save.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function checkForNewerSave has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

export const checkForNewerSave = async (
    config: IConfig,
    { saveVersion }: ICheckForNewerSaveParameters,
    logger: ILogger = debug
): Promise<number> => {
Severity: Minor
Found in packages/nucleus/src/endpoints/check-for-newer-save.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return logger.fatal(new Error("Hash verification failed when checking for newer save"));
Severity: Major
Found in packages/nucleus/src/endpoints/check-for-newer-save.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return logger.fatal(new Error("Bad server response"));
    Severity: Major
    Found in packages/nucleus/src/endpoints/check-for-newer-save.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return 0;
      Severity: Major
      Found in packages/nucleus/src/endpoints/check-for-newer-save.ts - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status