lesander/fritzbox.js

View on GitHub

Showing 21 of 21 total issues

Function CallMonitor has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var CallMonitor = function (options) {
  let self = this
  this.call = {}

  /**
Severity: Major
Found in src/fon.js - About 3 hrs to fix

    Function getTamMessages has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    fritzFon.getTamMessages = async (options) => {
      const version = await fritzSystem.getVersionNumber(options)
    
      if (version.error) return version
    
    
    Severity: Minor
    Found in src/fon.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function request has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    fritzRequest.request = async (path, method, options, pipe = false, formData = false, formUrlEncoded = false) => {
      options.protocol = options.protocol || 'https'
    
      // Make sure we have the required options.
      if (!options.server || options.server === '') {
    Severity: Minor
    Found in src/request.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function request has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    fritzRequest.request = async (path, method, options, pipe = false, formData = false, formUrlEncoded = false) => {
      options.protocol = options.protocol || 'https'
    
      // Make sure we have the required options.
      if (!options.server || options.server === '') {
    Severity: Minor
    Found in src/request.js - About 1 hr to fix

      Function getTamMessages has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      fritzFon.getTamMessages = async (options) => {
        const version = await fritzSystem.getVersionNumber(options)
      
        if (version.error) return version
      
      
      Severity: Minor
      Found in src/fon.js - About 1 hr to fix

        Function toggleSwitch has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        fritzDect.toggleSwitch = async (deviceId, value, options) => {
          const version = await fritzSystem.getVersionNumber(options)
          if (version.error) return version
        
          let response
        Severity: Minor
        Found in src/dect.js - About 1 hr to fix

          Function phonebook has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          fritzFormat.phonebook = (phonebook) => {
            let formattedPhonebook = []
            for (var i in phonebook) {
              formattedPhonebook[i] = {
                uniqueId: phonebook[i].uniqueid[0],
          Severity: Minor
          Found in src/format.js - About 1 hr to fix

            Function toggleSwitch has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            fritzDect.toggleSwitch = async (deviceId, value, options) => {
              const version = await fritzSystem.getVersionNumber(options)
              if (version.error) return version
            
              let response
            Severity: Minor
            Found in src/dect.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function phonebook has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            fritzFormat.phonebook = (phonebook) => {
              let formattedPhonebook = []
              for (var i in phonebook) {
                formattedPhonebook[i] = {
                  uniqueId: phonebook[i].uniqueid[0],
            Severity: Minor
            Found in src/format.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

              return sessionId
            Severity: Major
            Found in src/login.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return { message: 'Set switch to given state.', deviceId: responseObject.deviceId }
              Severity: Major
              Found in src/dect.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  return formtattedTamMessages
                Severity: Major
                Found in src/fon.js - About 30 mins to fix

                  Parsing error: Unexpected token =>
                  Open

                  fritzRequest.request = async (path, method, options, pipe = false, formData = false, formUrlEncoded = false) => {
                  Severity: Minor
                  Found in src/request.js by eslint

                  For more information visit Source: http://eslint.org/docs/rules/

                  Parsing error: Unexpected token =>
                  Open

                  fritzLogin.getSessionId = async (options) => {
                  Severity: Minor
                  Found in src/login.js by eslint

                  For more information visit Source: http://eslint.org/docs/rules/

                  Parsing error: Unexpected token =>
                  Open

                  fritzDect.getSmartDevices = async (options) => {
                  Severity: Minor
                  Found in src/dect.js by eslint

                  For more information visit Source: http://eslint.org/docs/rules/

                  Unexpected require().
                  Open

                    debug: require('./package.json').options.debug
                  Severity: Minor
                  Found in index.js by eslint

                  Enforce require() on the top-level module scope (global-require)

                  In Node.js, module dependencies are included using the require() function, such as:

                  var fs = require("fs");

                  While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

                  function foo() {
                  
                      if (condition) {
                          var fs = require("fs");
                      }
                  }

                  Since require() does a synchronous load, it can cause performance problems when used in other locations.

                  Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

                  Rule Details

                  This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

                  Examples of incorrect code for this rule:

                  /*eslint global-require: "error"*/
                  /*eslint-env es6*/
                  
                  // calling require() inside of a function is not allowed
                  function readFile(filename, callback) {
                      var fs = require('fs');
                      fs.readFile(filename, callback)
                  }
                  
                  // conditional requires like this are also not allowed
                  if (DEBUG) { require('debug'); }
                  
                  // a require() in a switch statement is also flagged
                  switch(x) { case '1': require('1'); break; }
                  
                  // you may not require() inside an arrow function body
                  var getModule = (name) => require(name);
                  
                  // you may not require() inside of a function body as well
                  function getModule(name) { return require(name); }
                  
                  // you may not require() inside of a try/catch block
                  try {
                      require(unsafeModule);
                  } catch(e) {
                      console.log(e);
                  }

                  Examples of correct code for this rule:

                  /*eslint global-require: "error"*/
                  
                  // all these variations of require() are ok
                  require('x');
                  var y = require('y');
                  var z;
                  z = require('z').initialize();
                  
                  // requiring a module and using it in a function is ok
                  var fs = require('fs');
                  function readFile(filename, callback) {
                      fs.readFile(filename, callback)
                  }
                  
                  // you can use a ternary to determine which module to require
                  var logger = DEBUG ? require('dev-logger') : require('logger');
                  
                  // if you want you can require() at the end of your module
                  function doSomethingA() {}
                  function doSomethingB() {}
                  var x = require("x"),
                      z = require("z");

                  When Not To Use It

                  If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

                  Parsing error: Unexpected token =>
                  Open

                  fritzSystem.getVersion = async (options) => {
                  Severity: Minor
                  Found in src/system.js by eslint

                  For more information visit Source: http://eslint.org/docs/rules/

                  Parsing error: Unexpected token =>
                  Open

                  fritzFon.getCalls = async (options) => {
                  Severity: Minor
                  Found in src/fon.js by eslint

                  For more information visit Source: http://eslint.org/docs/rules/

                  Unexpected require().
                  Open

                    version: require('./package.json').version,
                  Severity: Minor
                  Found in index.js by eslint

                  Enforce require() on the top-level module scope (global-require)

                  In Node.js, module dependencies are included using the require() function, such as:

                  var fs = require("fs");

                  While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

                  function foo() {
                  
                      if (condition) {
                          var fs = require("fs");
                      }
                  }

                  Since require() does a synchronous load, it can cause performance problems when used in other locations.

                  Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

                  Rule Details

                  This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

                  Examples of incorrect code for this rule:

                  /*eslint global-require: "error"*/
                  /*eslint-env es6*/
                  
                  // calling require() inside of a function is not allowed
                  function readFile(filename, callback) {
                      var fs = require('fs');
                      fs.readFile(filename, callback)
                  }
                  
                  // conditional requires like this are also not allowed
                  if (DEBUG) { require('debug'); }
                  
                  // a require() in a switch statement is also flagged
                  switch(x) { case '1': require('1'); break; }
                  
                  // you may not require() inside an arrow function body
                  var getModule = (name) => require(name);
                  
                  // you may not require() inside of a function body as well
                  function getModule(name) { return require(name); }
                  
                  // you may not require() inside of a try/catch block
                  try {
                      require(unsafeModule);
                  } catch(e) {
                      console.log(e);
                  }

                  Examples of correct code for this rule:

                  /*eslint global-require: "error"*/
                  
                  // all these variations of require() are ok
                  require('x');
                  var y = require('y');
                  var z;
                  z = require('z').initialize();
                  
                  // requiring a module and using it in a function is ok
                  var fs = require('fs');
                  function readFile(filename, callback) {
                      fs.readFile(filename, callback)
                  }
                  
                  // you can use a ternary to determine which module to require
                  var logger = DEBUG ? require('dev-logger') : require('logger');
                  
                  // if you want you can require() at the end of your module
                  function doSomethingA() {}
                  function doSomethingB() {}
                  var x = require("x"),
                      z = require("z");

                  When Not To Use It

                  If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

                  Parsing error: Unexpected token =>
                  Open

                  fritzFormat.xmlToObject = async (xml) => {
                  Severity: Minor
                  Found in src/format.js by eslint

                  For more information visit Source: http://eslint.org/docs/rules/

                  Severity
                  Category
                  Status
                  Source
                  Language