Sign upLogin

lflux/eve-sdeloader

View on GitHub
Star
universe/constellation.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method Region.ImportConstellation has 80 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *Region) ImportConstellation(path string) error {
    f, err := os.Open(path)
    if err != nil {
        return err
    }
Severity: Major
Found in universe/constellation.go - About 2 hrs to fix

    Method Region.ImportConstellation has 10 return statements (exceeds 4 allowed).
    Open

    func (r *Region) ImportConstellation(path string) error {
    f, err := os.Open(path)
    if err != nil {
        return err
    }
    Severity: Major
    Found in universe/constellation.go - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (r *Region) ImportConstellations() error {
    constellations, err := filepath.Glob(filepath.Join(r.path, "*", "constellation.staticdata"))
    if err != nil {
        return err
    }
      Severity: Minor
      Found in universe/constellation.go and 1 other location - About 35 mins to fix
      universe/system.go on lines 307..322

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 106.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      exported method Region.ImportConstellations should have comment or be unexported
      Open

      func (r *Region) ImportConstellations() error {
      Severity: Minor
      Found in universe/constellation.go by golint

      exported method Region.ImportConstellation should have comment or be unexported
      Open

      func (r *Region) ImportConstellation(path string) error {
      Severity: Minor
      Found in universe/constellation.go by golint

      exported type Constellation should have comment or be unexported
      Open

      type Constellation struct {
      Severity: Minor
      Found in universe/constellation.go by golint

      There are no issues that match your filters.

      Category
      Status