lflux/eve-sdeloader

View on GitHub
universe/system.go

Summary

Maintainability
C
1 day
Test Coverage

Method Constellation.ImportSystem has 181 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *Constellation) ImportSystem(path string) error {
    f, err := os.Open(path)
    if err != nil {
        return err
    }
Severity: Major
Found in universe/system.go - About 6 hrs to fix

    Method Constellation.ImportSystem has 19 return statements (exceeds 4 allowed).
    Open

    func (c *Constellation) ImportSystem(path string) error {
        f, err := os.Open(path)
        if err != nil {
            return err
        }
    Severity: Major
    Found in universe/system.go - About 1 hr to fix

      Method Constellation.ImportSystem has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
      Open

      func (c *Constellation) ImportSystem(path string) error {
          f, err := os.Open(path)
          if err != nil {
              return err
          }
      Severity: Minor
      Found in universe/system.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (c *Constellation) ImportSystems() error {
          systems, err := filepath.Glob(filepath.Join(c.path, "*", "solarsystem.staticdata"))
          if err != nil {
              return err
          }
      Severity: Minor
      Found in universe/system.go and 1 other location - About 35 mins to fix
      universe/constellation.go on lines 119..133

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 106.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      exported type Stargate should have comment or be unexported
      Open

      type Stargate struct {
      Severity: Minor
      Found in universe/system.go by golint

      exported type Moon should have comment or be unexported
      Open

      type Moon struct {
      Severity: Minor
      Found in universe/system.go by golint

      exported type NPCStation should have comment or be unexported
      Open

      type NPCStation struct {
      Severity: Minor
      Found in universe/system.go by golint

      exported type Moons should have comment or be unexported
      Open

      type Moons []Moon
      Severity: Minor
      Found in universe/system.go by golint

      exported method Constellation.ImportSystem should have comment or be unexported
      Open

      func (c *Constellation) ImportSystem(path string) error {
      Severity: Minor
      Found in universe/system.go by golint

      exported method Constellation.ImportSystems should have comment or be unexported
      Open

      func (c *Constellation) ImportSystems() error {
      Severity: Minor
      Found in universe/system.go by golint

      exported type Star should have comment or be unexported
      Open

      type Star struct {
      Severity: Minor
      Found in universe/system.go by golint

      exported type SecondarySun should have comment or be unexported
      Open

      type SecondarySun struct {
      Severity: Minor
      Found in universe/system.go by golint

      exported type SolarSystem should have comment or be unexported
      Open

      type SolarSystem struct {
      Severity: Minor
      Found in universe/system.go by golint

      There are no issues that match your filters.

      Category
      Status