lflux/eve-sdeloader

View on GitHub
volumes/import.go

Summary

Maintainability
B
4 hrs
Test Coverage

Function ImportVolume1 has 5 return statements (exceeds 4 allowed).
Open

func ImportVolume1(db *sql.DB, path string) error {
    defer utils.TimeTrack(time.Now(), "volume1")

    records, err := readCSV(path)
    if err != nil {
Severity: Major
Found in volumes/import.go - About 35 mins to fix

    Function ImportVolume2 has 5 return statements (exceeds 4 allowed).
    Open

    func ImportVolume2(db *sql.DB, path string) error {
        defer utils.TimeTrack(time.Now(), "volume2")
    
        records, err := readCSV(path)
        if err != nil {
    Severity: Major
    Found in volumes/import.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func ImportVolume2(db *sql.DB, path string) error {
          defer utils.TimeTrack(time.Now(), "volume2")
      
          records, err := readCSV(path)
          if err != nil {
      Severity: Major
      Found in volumes/import.go and 1 other location - About 1 hr to fix
      volumes/import.go on lines 48..71

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 181.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func ImportVolume1(db *sql.DB, path string) error {
          defer utils.TimeTrack(time.Now(), "volume1")
      
          records, err := readCSV(path)
          if err != nil {
      Severity: Major
      Found in volumes/import.go and 1 other location - About 1 hr to fix
      volumes/import.go on lines 73..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 181.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      exported function ImportVolume2 should have comment or be unexported
      Open

      func ImportVolume2(db *sql.DB, path string) error {
      Severity: Minor
      Found in volumes/import.go by golint

      exported function ImportVolume1 should have comment or be unexported
      Open

      func ImportVolume1(db *sql.DB, path string) error {
      Severity: Minor
      Found in volumes/import.go by golint

      There are no issues that match your filters.

      Category
      Status