lfzawacki/musical-artifacts

View on GitHub

Showing 11 of 11 total issues

Class Artifact has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

class Artifact < ActiveRecord::Base
    include AutoHtml

    # TODO: extract out to another file?
    # Collect activity from creates, edits and deletions
Severity: Minor
Found in app/models/artifact.rb - About 3 hrs to fix

    Method create_with_omniauth has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def create_with_omniauth
        # Get the email from the form if it's present
        # We won't link accounts this way
        if params[:user] && params[:user][:email]
          session[:omniauth_cache]['info']['email'] = params[:user][:email]
    Severity: Minor
    Found in app/controllers/users/auth_callbacks_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method type_image has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.type_image name, small=false
        # All gpls use the same image
        if name.match(/gpl/)
          name = 'gpl'
        end
    Severity: Minor
    Found in app/models/license.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method insert_hash has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def insert_hash(hash, path, value)
        head, *tail = path
        if tail.empty?
          hash.merge(head => value)
        else
    Severity: Minor
    Found in app/helpers/artifacts_helper.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method title_from_tags has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def title_from_tags tags
        title = ''
    
        if tags[:apps].present?
          title += tags[:apps].split(',').join(', ')
    Severity: Minor
    Found in app/helpers/artifacts_helper.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method perform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.perform(user_id)
        user = User.find(user_id)
    
        # Only fetch from users who registered with email
        puts "* [avatar] Fetching username/avatar for #{user.email.truncate(8)}"
    Severity: Minor
    Found in app/workers/get_public_avatar_data_worker.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method api_authenticate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def api_authenticate
    
        if current_user.blank? && request.headers['Authorization'].present?
          @current_user ||= begin
            token = request.headers['Authorization'].split.last
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method order_by_params has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def order_by_params
          order_str = params[:order]
          direction = params[:asc] ? 'ASC' : 'DESC'
    
          if ['top_rated', 'most_downloaded', 'name',
    Severity: Minor
    Found in app/controllers/artifacts_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method external_link_to has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def external_link_to text, link=nil, opt=nil
        if block_given?
          link ||={}
          link_to(text, rel: 'nofollow', target: '_blank', class: link[:class] || "external-link normal") do
            yield
    Severity: Minor
    Found in app/helpers/artifacts_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def initialize(user)
    
        can :download, Artifact do |artifact|
          artifact.downloadable? && artifact.approved?
        end
    Severity: Minor
    Found in app/models/ability.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method remove_duplicated_tags_from_searches has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def remove_duplicated_tags_from_searches
          tag_fields = [:q, :tags, :apps, :formats]
          counts = {}
          reversed = {}
    
    
    Severity: Minor
    Found in app/controllers/artifacts_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language