Sign upLogin

lgaticaq/info-rut

View on GitHub
Star

Showing 5 of 5 total issues

Function getData has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const getData = params => {
  return new Promise((resolve, reject) => {
    const paths = new Map([
      ['rut', '/rut'],
      ['name', '/buscar']
Severity: Major
Found in src/index.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const getPersonByRut = async rut => {
  if (!validate(rut)) return null
  const params = {
    type: 'person',
    term: format(rut),
    Severity: Major
    Found in src/index.js and 1 other location - About 2 hrs to fix
    src/index.js on lines 160..170

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const getEnterpriseByRut = async rut => {
  if (!validate(rut)) return null
  const params = {
    type: 'enterprise',
    term: format(rut),
    Severity: Major
    Found in src/index.js and 1 other location - About 2 hrs to fix
    src/index.js on lines 140..150

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 92.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function req has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const req = https.request(options, res => {
      if (res.statusCode !== 200) {
        reject(new Error(`Request Failed. Status Code: ${res.statusCode}`))
      } else {
        res.setEncoding('utf8')
    Severity: Minor
    Found in src/index.js - About 2 hrs to fix

      Function data has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                const data = Array.from($('table tbody tr')).map(el => {
            const keys = new Map([
              [
                'person',
                new Map([
      Severity: Minor
      Found in src/index.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language