Sign upLogin

lgaticaq/tbk-oneclick

View on GitHub
Star

Showing 8 of 8 total issues

Function params has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

  params() {
    if (!this._xmlResult) {
      const result = {};
      for (let e of this.xmlResponse.findall('.//return')) {
        let isAction = false;
Severity: Minor
Found in src/response.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  validate() {
    if (!this.xmlResponse) {
      this.error = 'SoapServerError';
      this.errorMsg = 'invalid XML response';
      this.userErrorMsg = 'Error al realizar la operación';
Severity: Minor
Found in src/response.js - About 1 hr to fix

    Function params has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      params() {
    if (!this._xmlResult) {
      const result = {};
      for (let e of this.xmlResponse.findall('.//return')) {
        let isAction = false;
    Severity: Minor
    Found in src/response.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            } else if (this.action === 'codeReverseOneClick' && !this.params().reversed) {
        this.error = 'codeReverseOneClickError';
        this.errorMsg = 'imposible revertir la compra';
        this.userErrorMsg = this.errorMsg;
        this.extra = {reversed: false};
      Severity: Major
      Found in src/response.js and 1 other location - About 1 hr to fix
      src/response.js on lines 210..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            } else if (this.action === 'removeUser' && !this.params().removed) {
        this.error = 'removeUserError';
        this.errorMsg = 'imposible eliminar la inscripción';
        this.userErrorMsg = this.errorMsg;
        this.extra = {removed: false};
      Severity: Major
      Found in src/response.js and 1 other location - About 1 hr to fix
      src/response.js on lines 215..220

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for(let ns of namespaces) {
      let idx = Object.keys(element).indexOf(ns);
      element = element[idx][ns];
    }
      Severity: Minor
      Found in src/response.js and 1 other location - About 50 mins to fix
      src/response.js on lines 91..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          for(let ns of namespaces) {
      let idx = Object.keys(element).indexOf(ns);
      element = element[idx][ns];
    }
      Severity: Minor
      Found in src/response.js and 1 other location - About 50 mins to fix
      src/response.js on lines 74..77

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        validate() {
    if (!this.xmlResponse) {
      this.error = 'SoapServerError';
      this.errorMsg = 'invalid XML response';
      this.userErrorMsg = 'Error al realizar la operación';
      Severity: Minor
      Found in src/response.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language