Sign upLogin

lgaticaq/tz-parser

View on GitHub
Star

Showing 28 of 28 total issues

File responses.js has 486 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict'

const nmea = require('node-nmea')
const patterns = require('./patterns')
const langEs = require('./messages/es.json')
Severity: Minor
Found in src/responses.js - About 7 hrs to fix

    Function getCommand has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const getCommand = (raw, lang) => {
  const messages = langs[lang] || langs['es']
  const match = patterns.receiveOk.exec(raw.toString())
  const password = match[1]
  const code = match[2]
    Severity: Major
    Found in src/responses.js - About 2 hrs to fix

      Function exports has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = raw => {
  const match = patterns.avl08.exec(raw.toString())
  const gprmcData = nmea.parse(match[4])
  const data = {
    raw: match[0],
      Severity: Major
      Found in src/avl08.js - About 2 hrs to fix

        Function exports has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = raw => {
  const match = patterns.avl05.exec(raw.toString())
  const gprmcData = nmea.parse(match[4])
  const data = {
    raw: match[0],
        Severity: Major
        Found in src/avl05.js - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            } else {
    if (dir.split('.')[0].length === 5) {
      raw = `${dir.substr(1)},N`
    } else {
      raw = `${dir.substr(1)},E`
          Severity: Major
          Found in src/responses.js and 1 other location - About 2 hrs to fix
          src/responses.js on lines 54..60

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            if (/^-/.test(dir)) {
    if (dir.split('.')[0].length === 5) {
      raw = `${dir.substr(1)},S`
    } else {
      raw = `${dir.substr(1)},W`
          Severity: Major
          Found in src/responses.js and 1 other location - About 2 hrs to fix
          src/responses.js on lines 60..66

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function exports has 56 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = raw => {
  const match = patterns.avl201.exec(raw.toString())
  const gprmcData = nmea.parse(match[4])
  const data = {
    raw: match[0],
          Severity: Major
          Found in src/avl201.js - About 2 hrs to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                voltage: {
      battery: parseInt(match[34], 10) / 100,
      inputCharge: parseInt(match[35], 10) / 100,
      ada: parseInt(match[36], 10) / 100,
      adb: parseInt(match[37], 10) / 100
            Severity: Major
            Found in src/avl08.js and 1 other location - About 2 hrs to fix
            src/avl05.js on lines 51..56

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                voltage: {
      battery: parseInt(match[34], 10) / 100,
      inputCharge: parseInt(match[35], 10) / 100,
      ada: parseInt(match[36], 10) / 100,
      adb: parseInt(match[37], 10) / 100
            Severity: Major
            Found in src/avl05.js and 1 other location - About 2 hrs to fix
            src/avl08.js on lines 54..59

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function exports has 51 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = data => {
  const match = patterns.info.exec(data.toString())
  const lat = degToDec(match[1].replace(/(\d+)\.(\d+)(\w{1})/, '$1.$2,$3'))
  const lng = degToDec(match[2].replace(/(\d+)\.(\d+)(\w{1})/, '$1.$2,$3'))
  return {
            Severity: Major
            Found in src/info.js - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              const parseSetdataflash = data => {
  const state = data.instruction.split('_')[2]
  const digit = state === 'on' ? 1 : 0
  return `*${data.password},601,${digit}#`
}
              Severity: Major
              Found in src/commands.js and 1 other location - About 1 hr to fix
              src/commands.js on lines 101..105

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              const parseSetHeartbeatSwitch = data => {
  const state = data.instruction.split('_')[2]
  const digit = state === 'on' ? 1 : 0
  return `*${data.password},040,${digit}#`
}
              Severity: Major
              Found in src/commands.js and 1 other location - About 1 hr to fix
              src/commands.js on lines 65..69

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    input: {
        '1': match[22] === '1',
        '2': match[23] === '1',
        '3': match[24] === '1',
        '4': match[25] === '1',
              Severity: Major
              Found in src/avl05.js and 1 other location - About 1 hr to fix
              src/avl08.js on lines 33..39

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 71.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    input: {
        '1': match[24] === '1',
        '2': match[25] === '1',
        '3': match[26] === '1',
        '4': match[27] === '1',
              Severity: Major
              Found in src/avl08.js and 1 other location - About 1 hr to fix
              src/avl05.js on lines 32..38

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 71.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              const parseSetAccAlarm = extra => {
  return {
    command: 'SETACCALARM',
    enable: extra[0] === '1',
    acceleration: parseInt(extra[1], 10),
              Severity: Major
              Found in src/responses.js and 1 other location - About 1 hr to fix
              src/responses.js on lines 397..404

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 63.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function getAlarm has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const getAlarm = (alarm, speed, rfid) => {
  const messages = langs['es']
  const alarmTypes = {
    '01': { type: 'SOS_Button', message: messages[alarm] },
    '49': { type: 'DI', number: 5, status: true, message: messages[alarm] },
              Severity: Minor
              Found in src/utils.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                const parseSettrackinginterval = extra => {
  return {
    command: 'SETTRACKINGINTERVAL',
    enable: extra[0] === '1',
    intervalOn: parseInt(extra[1], 10),
                Severity: Major
                Found in src/responses.js and 1 other location - About 1 hr to fix
                src/responses.js on lines 334..341

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 63.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function parseCommand has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                const parseCommand = data => {
  let command = null
  data.password = data.password || '000000'
  const parsers = [
    { pattern: /^set_password$/, parser: parseSetUserPassword },
                Severity: Minor
                Found in src/commands.js - About 1 hr to fix

                  Function parseDir has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  const parseDir = dir => {
  let raw
  if (/^-/.test(dir)) {
    if (dir.split('.')[0].length === 5) {
      raw = `${dir.substr(1)},S`
                  Severity: Minor
                  Found in src/responses.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                  const parseSetintervalgprsstandby = extra => {
  return {
    command: 'SETINTERVALGPRSSTANDBY',
    enable: extra[0] === '1',
    interval: parseInt(extra[1], 10)
                  Severity: Major
                  Found in src/responses.js and 3 other locations - About 40 mins to fix
                  src/responses.js on lines 326..332
                  src/responses.js on lines 406..412
                  src/responses.js on lines 422..428

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language