lgtome/rm-node-modules-cli

View on GitHub

Showing 5 of 5 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('Execute should not affect if marked files do not exist', async (t) => {
  const folder = `${process.cwd()}/emptyDirectory/node_modules`
  try {
    const entryPath = path.resolve(process.cwd(), 'emptyDirectory')
    await run(entryPath, 0, 'execute')
Severity: Major
Found in __tests__/execute.test.js and 1 other location - About 4 hrs to fix
__tests__/execute.test.js on lines 39..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

test('Execute should not affect if days not agreed', async (t) => {
  const folder = `${process.cwd()}/directory/node_modules`
  try {
    const entryPath = path.resolve(process.cwd(), 'directory')
    await run(entryPath, 14, 'execute')
Severity: Major
Found in __tests__/execute.test.js and 1 other location - About 4 hrs to fix
__tests__/execute.test.js on lines 50..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function run has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function run(entryPath, day = 14, type = 'check') {
  if (!entryPath || typeof day !== 'number' || !type) {
    return new Error('Arguments not provided!')
  }
  try {
Severity: Minor
Found in src/service/index.js - About 1 hr to fix

    Function run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    export async function run(entryPath, day = 14, type = 'check') {
      if (!entryPath || typeof day !== 'number' || !type) {
        return new Error('Arguments not provided!')
      }
      try {
    Severity: Minor
    Found in src/service/index.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function exec has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function exec(args) {
      const { entryPath, days = 14, type } = args
      const resolvedPath = getResolvedPath(entryPath)
      const { resolvedType, error } = getResolvedType(type)
      if (error) {
    Severity: Minor
    Found in src/run.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language