Sign upLogin

librato/librato-metrics

View on GitHub
Star
lib/librato/metrics/client.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Client has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Client
      extend Forwardable

      def_delegator :annotator, :add, :annotate
Severity: Minor
Found in lib/librato/metrics/client.rb - About 3 hrs to fix

    Method get_series has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def get_series(metric_name, options={})
        raise ArgumentError, ":resolution and :duration or :start_time must be set" if options.empty?
        query = options.dup
        if query[:start_time].respond_to?(:year)
          query[:start_time] = query[:start_time].to_i
    Severity: Minor
    Found in lib/librato/metrics/client.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status